Re: [PATCH for-10.1 v2 27/37] vfio: Make vfio_devices_query_dirty_bitmap() static

["Cédric Le Goater" <clg@redhat.com>]

On 4/2/25 14:43, Avihai Horon wrote:
> 
> On 26/03/2025 9:51, Cédric Le Goater wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> vfio_devices_query_dirty_bitmap() is only used in "container-base.c".
>> Also, rename to vfio_container_devices_query_dirty_bitmap() to reflect
>> with the prefix 'vfio_container_devices_' that it simply loops over
>> the container's device list.
>>
>> This rename also frees the vfio_devices_query_dirty_bitmap() name
>> which we will reuse in the next changes.
> 
> Nit: this sentence can be dropped, vfio_devices_query_dirty_bitmap() is not used in the following changes IIUC.

I was referring to vfio_container_query_dirty_bitmap() but I agree
the sentence is not that useful. Will drop.

>>
>> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> 
> Reviewed-by: Avihai Horon <avihaih@nvidia.com>
> 

Since lore didn't receive the email :

Reviewed-by: Avihai Horon <avihaih@nvidia.com>


Thanks,

C.