Re: [PATCH 1/6] target/mips: Introduce register access helper functions

[Richard Henderson <richard.henderson@linaro.org>]

On 10/25/22 01:23, Jiaxun Yang wrote:
> Introduce register access functions with value extend capability
> to prepare for decodetree based translation implmentation.
> 
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
>   target/mips/tcg/translate.c | 143 +++++++++++++++++++++++++++++++++++-
>   target/mips/tcg/translate.h |  54 ++++++++++++++
>   2 files changed, 196 insertions(+), 1 deletion(-)
> 
> diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c
> index de1511baaf..b5d595ef34 100644
> --- a/target/mips/tcg/translate.c
> +++ b/target/mips/tcg/translate.c
> @@ -1196,6 +1196,17 @@ enum {
>       MMI_OPC_MADDU1     = 0x21 | MMI_OPC_CLASS_MMI,
>   };
>   
> +/*
> + * If an operation is being performed on less than TARGET_LONG_BITS,
> + * it may require the inputs to be sign- or zero-extended; which will
> + * depend on the exact operation being performed.
> + */
> +typedef enum {
> +    EXT_NONE,
> +    EXT_SIGN,
> +    EXT_ZERO
> +} DisasExtend;

Remove as duplicate -- this is also in translate.h.  I'm surprised no compile error.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~