From: Paolo Bonzini <pbonzini@redhat.com>
To: Like Xu <like.xu@linux.intel.com>
Cc: Wanpeng Li <wanpengli@tencent.com>,
Eduardo Habkost <ehabkost@redhat.com>,
kvm@vger.kernel.org, Joerg Roedel <joro@8bytes.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
linux-kernel@vger.kernel.org,
Sean Christopherson <sean.j.christopherson@intel.com>,
qemu-devel@nongnu.org, Vitaly Kuznetsov <vkuznets@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Jim Mattson <jmattson@google.com>
Subject: Re: [Qemu-devel PATCH] target/i386: define a new MSR based feature word - FEAT_PERF_CAPABILITIES
Date: Fri, 29 May 2020 12:23:59 +0200 [thread overview]
Message-ID: <1aa68600-e48d-fa83-b2e2-b070a486afd4@redhat.com> (raw)
In-Reply-To: <20200529074347.124619-5-like.xu@linux.intel.com>
On 29/05/20 09:43, Like Xu wrote:
> + if (!cpu->enable_pmu) {
> + *ecx &= ~CPUID_EXT_PDCM;
> + }
> break;
> case 2:
> /* cache info: needed for Pentium Pro compatibility */
> @@ -6505,6 +6528,12 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp)
> }
> }
>
> + if (kvm_enabled() && cpu->enable_pmu &&
> + (kvm_arch_get_supported_cpuid(kvm_state, 1, 0, R_ECX) &
> + CPUID_EXT_PDCM)) {
> + env->features[FEAT_1_ECX] |= CPUID_EXT_PDCM;
> + }
> +
I'm dropping this hunk two hunks because it's going to break live
migration with e.g. "-cpu IvyBridge,pmu=on". We will have to add PDCM
by default only to future CPU models, but "-cpu host,pmu=on" will pick
it up automatically.
Paolo
prev parent reply other threads:[~2020-05-29 10:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200529074347.124619-1-like.xu@linux.intel.com>
2020-05-29 7:43 ` [Qemu-devel PATCH] target/i386: define a new MSR based feature word - FEAT_PERF_CAPABILITIES Like Xu
2020-05-29 10:23 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1aa68600-e48d-fa83-b2e2-b070a486afd4@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=like.xu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sean.j.christopherson@intel.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).