From: Eric Blake <eblake@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Neil Skrypuch <neil@tembosocial.com>,
Max Reitz <mreitz@redhat.com>,
Stefano Garzarella <sgarzare@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] file-posix: add drop-cache=on|off option
Date: Wed, 6 Mar 2019 06:44:42 -0600 [thread overview]
Message-ID: <1aab9bb5-a8a1-b0c8-af6f-909631e9ce2f@redhat.com> (raw)
In-Reply-To: <20190306101811.GJ22159@stefanha-x1.localdomain>
[-- Attachment #1: Type: text/plain, Size: 902 bytes --]
On 3/6/19 4:18 AM, Stefan Hajnoczi wrote:
>> Question - if we used qapi's 'if':COND to only declare the field on
>> platforms where we know at compile time that we can support it, would
>> that be enough for libvirt to introspect that if the field exists then
>> migration is safe, without having to rely on an query-qemu-features command?
>
> Yes, although this raises another question:
>
> The drop-cache implementation is not #ifdefed in file-posix.c. If we
> make the QMP schema conditional, should we also #ifdef the command-line
> option in raw_runtime_opts[] to prevent QEMU from silently ignoring this
> option?
Yes, that would make sense to me - if we don't advertise the feature,
then we should not silently ignore it on the command line.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-03-06 12:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 16:09 [Qemu-devel] [PATCH v2] file-posix: add drop-cache=on|off option Stefan Hajnoczi
2019-03-01 16:30 ` Eric Blake
2019-03-04 8:51 ` Markus Armbruster
2019-03-06 10:18 ` Stefan Hajnoczi
2019-03-06 12:44 ` Eric Blake [this message]
2019-03-06 12:50 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1aab9bb5-a8a1-b0c8-af6f-909631e9ce2f@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=neil@tembosocial.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).