Re: [PATCH v4] hw/core/loader: allow loading larger ROMs

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 28/6/24 20:27, Gregor Haas wrote:
> The read() syscall is not guaranteed to return all data from a file. The
> default ROM loader implementation currently does not take this into account,
> instead failing if all bytes are not read at once. This change loads the ROM
> using g_file_get_contents() instead, which correctly reads all data using
> multiple calls to read() while also returning the loaded ROM size.
> 
> Signed-off-by: Gregor Haas <gregorhaas1997@gmail.com>
> ---
>   hw/core/loader.c | 30 +++++-------------------------
>   1 file changed, 5 insertions(+), 25 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

and queued, thanks!