qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, anton.nefedov@virtuozzo.com,
	Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] iotests: Fix stuck NBD process on 33
Date: Mon, 12 Mar 2018 22:12:58 +0100	[thread overview]
Message-ID: <1ac1ca19-8f5f-0c6e-f676-699720fba303@redhat.com> (raw)
In-Reply-To: <20180312211156.452139-1-eblake@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 924 bytes --]

On 2018-03-12 22:11, Eric Blake wrote:
> Commit afe35cde6 added additional actions to test 33, but forgot
> to reset the image between tests.  As a result, './check -nbd 33'
> fails because the qemu-nbd process from the first half is still
> occupying the port, preventing the second half from starting a
> new qemu-nbd process.  Worse, the failure leaves a rogue qemu-nbd
> process behind even after the test fails, which causes knock-on
> failures to later tests that also want to start qemu-nbd.
> 
> Reported-by: Max Reitz <mreitz@redhat.com>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> 
> I'll take this through my NBD queue (pull request within the next 16
> hours), as obviously I want to test that the other patches on that
> queue can get past the iotests for NBD :)
> 
>  tests/qemu-iotests/033 | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Max Reitz <mreitz@redhat.com>


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]

  reply	other threads:[~2018-03-12 21:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-12 21:11 [Qemu-devel] [PATCH] iotests: Fix stuck NBD process on 33 Eric Blake
2018-03-12 21:12 ` Max Reitz [this message]
2018-03-13 10:44   ` Anton Nefedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ac1ca19-8f5f-0c6e-f676-699720fba303@redhat.com \
    --to=mreitz@redhat.com \
    --cc=anton.nefedov@virtuozzo.com \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).