[Qemu-devel] [PATCH] iotests: Fix stuck NBD process on 33

[Qemu-devel] [PATCH] iotests: Fix stuck NBD process on 33

[Eric Blake]

Commit afe35cde6 added additional actions to test 33, but forgot
to reset the image between tests.  As a result, './check -nbd 33'
fails because the qemu-nbd process from the first half is still
occupying the port, preventing the second half from starting a
new qemu-nbd process.  Worse, the failure leaves a rogue qemu-nbd
process behind even after the test fails, which causes knock-on
failures to later tests that also want to start qemu-nbd.

Reported-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
---

I'll take this through my NBD queue (pull request within the next 16
hours), as obviously I want to test that the other patches on that
queue can get past the iotests for NBD :)

 tests/qemu-iotests/033 | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/qemu-iotests/033 b/tests/qemu-iotests/033
index a1d8357331d..ee8a1338bbd 100755
--- a/tests/qemu-iotests/033
+++ b/tests/qemu-iotests/033
@@ -105,6 +105,7 @@ for align in 512 4k; do
 done
 done

+_cleanup_test_img

 # Trigger truncate that would shrink qcow2 L1 table, which is done by
 #   clearing one entry (8 bytes) with bdrv_co_pwrite_zeroes()
-- 
2.14.3

Re: [Qemu-devel] [PATCH] iotests: Fix stuck NBD process on 33

[Max Reitz]

[-- Attachment #1: Type: text/plain, Size: 924 bytes --]

On 2018-03-12 22:11, Eric Blake wrote:
> Commit afe35cde6 added additional actions to test 33, but forgot
> to reset the image between tests.  As a result, './check -nbd 33'
> fails because the qemu-nbd process from the first half is still
> occupying the port, preventing the second half from starting a
> new qemu-nbd process.  Worse, the failure leaves a rogue qemu-nbd
> process behind even after the test fails, which causes knock-on
> failures to later tests that also want to start qemu-nbd.
> 
> Reported-by: Max Reitz <mreitz@redhat.com>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> 
> I'll take this through my NBD queue (pull request within the next 16
> hours), as obviously I want to test that the other patches on that
> queue can get past the iotests for NBD :)
> 
>  tests/qemu-iotests/033 | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Max Reitz <mreitz@redhat.com>


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]

Re: [Qemu-devel] [PATCH] iotests: Fix stuck NBD process on 33

[Anton Nefedov]

On 13/3/2018 12:12 AM, Max Reitz wrote:
> On 2018-03-12 22:11, Eric Blake wrote:
>> Commit afe35cde6 added additional actions to test 33, but forgot
>> to reset the image between tests.  As a result, './check -nbd 33'
>> fails because the qemu-nbd process from the first half is still
>> occupying the port, preventing the second half from starting a
>> new qemu-nbd process.  Worse, the failure leaves a rogue qemu-nbd
>> process behind even after the test fails, which causes knock-on
>> failures to later tests that also want to start qemu-nbd.
>>
>> Reported-by: Max Reitz <mreitz@redhat.com>
>> Signed-off-by: Eric Blake <eblake@redhat.com>
>> ---
>>
>> I'll take this through my NBD queue (pull request within the next 16
>> hours), as obviously I want to test that the other patches on that
>> queue can get past the iotests for NBD :)
>>
>>   tests/qemu-iotests/033 | 1 +
>>   1 file changed, 1 insertion(+)
> 
> Reviewed-by: Max Reitz <mreitz@redhat.com>
> 

ack; thanks!