From: Cole Robinson <crobinso@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>, Cole Robinson <crobinso@redhat.com>
Subject: [Qemu-devel] [PATCH v3 2/3] vnc: Tweak error when init fails
Date: Tue, 5 May 2015 11:07:18 -0400 [thread overview]
Message-ID: <1ad1da2188f9e3301d2a452d6585786bb2852b0d.1430838327.git.crobinso@redhat.com> (raw)
In-Reply-To: <cover.1430838327.git.crobinso@redhat.com>
In-Reply-To: <cover.1430838327.git.crobinso@redhat.com>
Before:
qemu-system-x86_64: -display vnc=unix:/root/foo.sock: Failed to start VNC server on `(null)': Failed to bind socket to /root/foo.sock: Permission denied
After:
qemu-system-x86_64: -display vnc=unix:/root/foo.sock: Failed to start VNC server: Failed to bind socket to /root/foo.sock: Permission denied
Rather than tweak the string possibly show unix: value as well,
just drop the explicit display reporting. We already get the cli
string in the error message, that should be sufficient.
Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
v3:
No change
ui/vnc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index e1abf64..b3450ec 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3780,8 +3780,7 @@ int vnc_init_func(QemuOpts *opts, void *opaque)
vnc_display_init(id);
vnc_display_open(id, &local_err);
if (local_err != NULL) {
- error_report("Failed to start VNC server on `%s': %s",
- qemu_opt_get(opts, "display"),
+ error_report("Failed to start VNC server: %s",
error_get_pretty(local_err));
error_free(local_err);
exit(1);
--
2.4.0
next prev parent reply other threads:[~2015-05-05 15:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 15:07 [Qemu-devel] [PATCH v3 0/3] vnc: Fixes for unix socket error handling Cole Robinson
2015-05-05 15:07 ` [Qemu-devel] [PATCH v3 1/3] vnc: Don't assert if opening unix socket fails Cole Robinson
2015-05-05 15:07 ` Cole Robinson [this message]
2015-05-05 15:07 ` [Qemu-devel] [PATCH v3 3/3] qemu-sockets: Report explicit error if unlink fails Cole Robinson
2015-05-05 15:20 ` [Qemu-devel] [PATCH v3 0/3] vnc: Fixes for unix socket error handling Eric Blake
2015-05-06 7:23 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ad1da2188f9e3301d2a452d6585786bb2852b0d.1430838327.git.crobinso@redhat.com \
--to=crobinso@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).