Re: [PATCH v18 13/14] hw/pci: Use -1 as the default value for rombar

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 4/1/25 08:52, Akihiko Odaki wrote:
> vfio_pci_size_rom() distinguishes whether rombar is explicitly set to 1
> by checking dev->opts, bypassing the QOM property infrastructure.
> 
> Use -1 as the default value for rombar to tell if the user explicitly
> set it to 1. The property is also converted from unsigned to signed.
> -1 is signed so it is safe to give it a new meaning. The values in
> [2 ^ 31, 2 ^ 32) become invalid, but nobody should have typed these
> values by chance.
> 
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> ---
>   include/hw/pci/pci_device.h | 2 +-
>   hw/pci/pci.c                | 2 +-
>   hw/vfio/pci.c               | 5 ++---
>   3 files changed, 4 insertions(+), 5 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>