From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: "Michael Roth" <michael.roth@amd.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH 4/5] crypto: push error reporting into TLS session I/O APIs
Date: Mon, 22 Jul 2024 16:37:31 +0200 [thread overview]
Message-ID: <1ae5a1f5-981c-4e83-a2b5-36f8d92f46f4@linaro.org> (raw)
In-Reply-To: <20240722131611.2820041-5-berrange@redhat.com>
On 22/7/24 15:16, Daniel P. Berrangé wrote:
> The current TLS session I/O APIs just return a synthetic errno
> value on error, which has been translated from a gnutls error
> value. This looses a large amount of valuable information that
> distinguishes different scenarios.
>
> Pushing population of the "Error *errp" object into the TLS
> session I/O APIs gives more detailed error information.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> crypto/tlssession.c | 47 ++++++++++++++++---------------------
> include/crypto/tlssession.h | 23 ++++++++++++++----
> io/channel-tls.c | 44 ++++++++++++++--------------------
> 3 files changed, 57 insertions(+), 57 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-07-22 14:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-22 13:16 [PATCH 0/5] crypto: improve error reporting detail Daniel P. Berrangé
2024-07-22 13:16 ` [PATCH 1/5] qapi: allow for g_autoptr(Error) usage Daniel P. Berrangé
2024-07-22 14:31 ` Philippe Mathieu-Daudé
2024-07-23 11:36 ` Markus Armbruster
2024-07-23 13:06 ` Daniel P. Berrangé
2024-07-24 8:17 ` Markus Armbruster
2024-07-22 13:16 ` [PATCH 2/5] chardev: add tracing of socket error conditions Daniel P. Berrangé
2024-07-22 14:31 ` Philippe Mathieu-Daudé
2024-07-22 13:16 ` [PATCH 3/5] crypto: drop gnutls debug logging support Daniel P. Berrangé
2024-07-22 14:32 ` Philippe Mathieu-Daudé
2024-07-22 15:03 ` Daniel P. Berrangé
2024-07-22 13:16 ` [PATCH 4/5] crypto: push error reporting into TLS session I/O APIs Daniel P. Berrangé
2024-07-22 14:37 ` Philippe Mathieu-Daudé [this message]
2024-07-22 13:16 ` [PATCH 5/5] crypto: propagate errors from TLS session I/O callbacks Daniel P. Berrangé
2024-07-22 14:35 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ae5a1f5-981c-4e83-a2b5-36f8d92f46f4@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).