From: David Hildenbrand <david@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
Thomas Huth <thuth@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v2] s390x/tcg: Don't model FP registers as globals
Date: Mon, 4 Feb 2019 18:41:42 +0100 [thread overview]
Message-ID: <1affa165-8432-2923-ec5e-900986885c53@redhat.com> (raw)
In-Reply-To: <20190204183756.5bbf0782.cohuck@redhat.com>
>>> Reading/writing a floating point register means reading/writing memory now.
>>>
>>> Break up ugly in2_x2() handling that modifies both, in1 and in2 into
>>> in1_x2l and in2_x2h. This makes things more readable. Also, in1_x1() is
>>
>> s/in1_x2l/in2_x2l/
>> s/in1_x2h/in2_x2h/
>
> Confused... it's already in2_x2h, I suppose that one should stay like
> it is?
Yes, I guess I am the confused one ;)
>
>>
>>
>> Sorry Conny, I assume when you pick this up, you can fix this up :)
>
> I would recommend a spell checker, only it would not help for the last
> case :)
I once tried to add a pre-commit hook for that, but it didn't work that
reliably. And if it's not automated, I guess I will forget it again.
... as long as the code is not in a similar shape, we're fine ;)
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2019-02-04 17:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 15:44 [Qemu-devel] [PATCH v2] s390x/tcg: Don't model FP registers as globals David Hildenbrand
2019-02-04 15:47 ` David Hildenbrand
2019-02-04 17:37 ` Cornelia Huck
2019-02-04 17:41 ` David Hildenbrand [this message]
2019-02-04 16:29 ` no-reply
2019-02-04 16:32 ` David Hildenbrand
2019-02-04 16:39 ` Cornelia Huck
2019-02-04 17:47 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1affa165-8432-2923-ec5e-900986885c53@redhat.com \
--to=david@redhat.com \
--cc=cohuck@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).