From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55122) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1Hdi-0002LZ-0M for qemu-devel@nongnu.org; Mon, 31 Oct 2016 14:49:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1Hdd-0001NB-Vl for qemu-devel@nongnu.org; Mon, 31 Oct 2016 14:48:58 -0400 References: <1477936293-17643-1-git-send-email-ashijeetacharya@gmail.com> From: Eric Blake Message-ID: <1b2e277f-322a-9229-0a2a-3ef90eb79bc0@redhat.com> Date: Mon, 31 Oct 2016 13:48:46 -0500 MIME-Version: 1.0 In-Reply-To: <1477936293-17643-1-git-send-email-ashijeetacharya@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BMfKE4Wn90vIqFiO8Nf05CUAqljdJMGIG" Subject: Re: [Qemu-devel] [PATCH] block/nbd: Fix the regression to free leaked visitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ashijeet Acharya , kwolf@redhat.com Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BMfKE4Wn90vIqFiO8Nf05CUAqljdJMGIG From: Eric Blake To: Ashijeet Acharya , kwolf@redhat.com Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com Message-ID: <1b2e277f-322a-9229-0a2a-3ef90eb79bc0@redhat.com> Subject: Re: [Qemu-devel] [PATCH] block/nbd: Fix the regression to free leaked visitor References: <1477936293-17643-1-git-send-email-ashijeetacharya@gmail.com> In-Reply-To: <1477936293-17643-1-git-send-email-ashijeetacharya@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/31/2016 12:51 PM, Ashijeet Acharya wrote: > This patch frees the leaked visitor in nbd_refresh_filename() and uses > visit_free() to fix it. >=20 > Signed-off-by: Ashijeet Acharya > --- > block/nbd.c | 1 + > 1 file changed, 1 insertion(+) Would be nice to mention that it was commit 491d6c7 that introduced the leak. Reviewed-by: Eric Blake >=20 > diff --git a/block/nbd.c b/block/nbd.c > index 8ef1438..ff9d01a 100644 > --- a/block/nbd.c > +++ b/block/nbd.c > @@ -545,6 +545,7 @@ static void nbd_refresh_filename(BlockDriverState *= bs, QDict *options) > qdict_put(opts, "tls-creds", qstring_from_str(s->tlscredsid));= > } > =20 > + visit_free(ov); > qdict_flatten(opts); > bs->full_open_options =3D opts; > } >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --BMfKE4Wn90vIqFiO8Nf05CUAqljdJMGIG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJYF5IPAAoJEKeha0olJ0NqoV8H/3jAkKCOHoZX0yCiHplk/2tl k2r3qjg7Kj+5xht8AEAMXgB7+za0S+W5v8uf2229jKL3Dk/sBqnxBlQ4vbnCAuzA p0tu/artaXTSvO76FOttHMHFXMLe9yd/38zjI8qMzXzdaQ/OCdZeru1aVxc3T2ZT idDwqKpLHknMCi90/zzGctLwfJyDdspFAsK/xyfb2TV0USmdFNCFTYghqGhKmiab KK/6G+JD4WF86bNk88oJaoIu2HoizXbrI1jInCcBFJbwhpcuHY3oK+ViOGlYYPYR OjdM7Y4XpelPwcUaDx0VLSjPvPy1ooNoNTrJbsLHEmj5ciyXsD7SZYHQw43L15s= =E3FG -----END PGP SIGNATURE----- --BMfKE4Wn90vIqFiO8Nf05CUAqljdJMGIG--