From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, mark.cave-ayland@ilande.co.uk, cota@braap.org
Subject: Re: [Qemu-devel] [PATCH v5 05/15] tests/tcg/minilib: support %c format char
Date: Wed, 1 May 2019 07:40:10 -0700 [thread overview]
Message-ID: <1b33ac75-d531-1a9d-46ea-f392249e2a19@linaro.org> (raw)
In-Reply-To: <20190430165234.32272-6-alex.bennee@linaro.org>
On 4/30/19 9:52 AM, Alex Bennée wrote:
> @@ -119,6 +119,10 @@ void ml_printf(const char *fmt, ...)
> str = va_arg(ap, char*);
> print_str(str);
> break;
> + case 'c':
> + c = (char) va_arg(ap, int);
> + __sys_outc(c);
> + break;
The assignment and cast are both unnecessary.
You could just as well write
__sys_outc(va_arg(ap, int))
but it's not wrong so
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2019-05-01 14:40 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 16:52 [Qemu-devel] [PATCH v5 00/15] demacro softmmu (plus tests/coverage) Alex Bennée
2019-04-30 16:52 ` Alex Bennée
2019-04-30 16:52 ` [Qemu-devel] [PATCH v5 01/15] tests/tcg/multiarch: add support for multiarch system tests Alex Bennée
2019-04-30 16:52 ` Alex Bennée
2019-05-01 18:35 ` Richard Henderson
2019-05-01 18:35 ` Richard Henderson
2019-04-30 16:52 ` [Qemu-devel] [PATCH v5 02/15] tests/tcg/multiarch: add hello world system test Alex Bennée
2019-04-30 16:52 ` Alex Bennée
2019-05-01 18:35 ` Richard Henderson
2019-05-01 18:35 ` Richard Henderson
2019-04-30 16:52 ` [Qemu-devel] [PATCH v5 03/15] tests/tcg/aarch64: add system boot.S Alex Bennée
2019-04-30 16:52 ` Alex Bennée
2019-05-01 14:37 ` Richard Henderson
2019-05-01 14:37 ` Richard Henderson
2019-05-01 14:57 ` Alex Bennée
2019-05-01 14:57 ` Alex Bennée
2019-05-08 17:45 ` Alex Bennée
2019-04-30 16:52 ` [Qemu-devel] [PATCH v5 04/15] tests/tcg/multiarch: move the system memory test Alex Bennée
2019-04-30 16:52 ` Alex Bennée
2019-05-01 18:35 ` Richard Henderson
2019-05-01 18:35 ` Richard Henderson
2019-04-30 16:52 ` [Qemu-devel] [PATCH v5 05/15] tests/tcg/minilib: support %c format char Alex Bennée
2019-04-30 16:52 ` Alex Bennée
2019-05-01 14:40 ` Richard Henderson [this message]
2019-05-01 14:40 ` Richard Henderson
2019-04-30 16:52 ` [Qemu-devel] [PATCH v5 06/15] tests/tcg/multiarch: expand system memory test to cover more Alex Bennée
2019-04-30 16:52 ` Alex Bennée
2019-05-01 14:44 ` Richard Henderson
2019-05-01 14:44 ` Richard Henderson
2019-04-30 16:52 ` [Qemu-devel] [PATCH v5 07/15] accel/tcg: demacro cputlb Alex Bennée
2019-04-30 16:52 ` Alex Bennée
2019-04-30 16:52 ` [Qemu-devel] [PATCH v5 08/15] cputlb: Move TLB_RECHECK handling into load/store_helper Alex Bennée
2019-04-30 16:52 ` Alex Bennée
2019-04-30 16:52 ` [Qemu-devel] [PATCH v5 09/15] accel/tcg: remove softmmu_template.h Alex Bennée
2019-04-30 16:52 ` Alex Bennée
2019-05-01 14:46 ` Richard Henderson
2019-05-01 14:46 ` Richard Henderson
2019-05-01 15:10 ` Alex Bennée
2019-05-01 15:10 ` Alex Bennée
2019-04-30 16:52 ` [Qemu-devel] [PATCH v5 10/15] cputlb: Drop attribute flatten Alex Bennée
2019-04-30 16:52 ` Alex Bennée
2019-04-30 16:52 ` [Qemu-devel] [PATCH v5 11/15] cputlb: Do unaligned load recursion to outermost function Alex Bennée
2019-04-30 16:52 ` Alex Bennée
2019-04-30 16:52 ` [Qemu-devel] [PATCH v5 12/15] cputlb: Do unaligned store " Alex Bennée
2019-04-30 16:52 ` Alex Bennée
2019-04-30 16:52 ` [Qemu-devel] [PATCH v5 13/15] Makefile: fix coverage-report reference to BUILD_DIR Alex Bennée
2019-04-30 16:52 ` Alex Bennée
2019-05-01 14:48 ` Richard Henderson
2019-05-01 14:48 ` Richard Henderson
2019-04-30 16:52 ` [Qemu-devel] [PATCH v5 14/15] Makefile: include per-target build directories in coverage report Alex Bennée
2019-04-30 16:52 ` Alex Bennée
2019-05-01 14:49 ` Richard Henderson
2019-05-01 14:49 ` Richard Henderson
2019-04-30 16:52 ` [Qemu-devel] [PATCH v5 15/15] Makefile.target: support per-target coverage reports Alex Bennée
2019-04-30 16:52 ` Alex Bennée
2019-05-01 14:50 ` Richard Henderson
2019-05-01 14:50 ` Richard Henderson
2019-05-01 18:39 ` [Qemu-devel] [PATCH v5 00/15] demacro softmmu (plus tests/coverage) Richard Henderson
2019-05-01 18:39 ` Richard Henderson
2019-05-03 19:28 ` Alex Bennée
2019-05-03 19:28 ` Alex Bennée
2019-05-10 10:36 ` Alex Bennée
2019-05-10 14:55 ` Mark Cave-Ayland
2019-05-10 17:01 ` Emilio G. Cota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b33ac75-d531-1a9d-46ea-f392249e2a19@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=cota@braap.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).