qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Subject: Re: MAINTAINERS still leaves more files uncovered than I'd like
Date: Mon, 2 Oct 2023 08:20:47 +0200	[thread overview]
Message-ID: <1b36bc2a-3bba-d876-5ea7-f3e37d9ec464@linaro.org> (raw)
In-Reply-To: <87lecp6w7x.fsf@pond.sub.org>

On 29/9/23 13:43, Markus Armbruster wrote:
> Back in 2014 (time flies), I posted
> 
>      Subject: MAINTAINERS leaves too many files uncovered
>      Message-ID: <87mw8rumhb.fsf@blackfin.pond.sub.org>
>      https://lore.kernel.org/qemu-devel/87mw8rumhb.fsf@blackfin.pond.sub.org/
> 
> I updated my findings in 2015, 2016 (at commit e00da552a0d), and 2018
> (at v3.1.0-rc2).  This is another update, at commit 36e9aab3c56.
> 
> Unsurprisingly, the number of files in the tree
> 
>      $ git-ls-files | wc -l
> 
> grows over time:
> 
>      year  2014  2015  2016  2018  2023
>      #     3746  4387  4921  6461  9788
> 
> Looks exponential to me, doubling every seven years or so.
> 
> The number of .c files has grown more slowly:
> 
>      year  2014  2015  2016  2018  2023
>      #     1836  1945  2132  2633  3588
> 
> The number of .c files not covered by MAINTAINERS
> 
>      $ for i in `git-ls-files`; do [ "`scripts/get_maintainer.pl -f --no-git-fallback $i | grep -v '^qemu-devel@nongnu\.org'`" ] || echo $i; done >unmaintained-files
>      $ grep -c '\.c$' unmaintained-files
> 
> went down a lot after my first post, but has since flatlined:
> 
>      year  2014  2015  2016  2018  2023
>      #     1066   461   402   259   246
> 
> It looks like we've pretty much stopped adding more unmaintained .c
> files, i.e. cherry-picking the kernel's 13f1937ef33 (checkpatch: emit a
> warning on file add/move/delete) as commit 4be6131e329 worked.
> 
> On the other hand, we're not making progress on the remaining old ones
> anymore.

How many new files without maintainers?
Shouldn't we turn this warning into an error, so new files must have
maintainers?


  parent reply	other threads:[~2023-10-02  6:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-29 11:43 MAINTAINERS still leaves more files uncovered than I'd like Markus Armbruster
2023-09-29 12:05 ` Cornelia Huck
2023-09-29 12:29   ` Thomas Huth
2023-09-29 14:35     ` Cornelia Huck
2023-10-02  6:18 ` Philippe Mathieu-Daudé
2023-10-02 18:25   ` Thomas Huth
2023-10-02  6:20 ` Philippe Mathieu-Daudé [this message]
2023-10-05 13:46   ` Markus Armbruster
2023-10-02 11:35 ` Cédric Le Goater
2023-10-05 13:50   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b36bc2a-3bba-d876-5ea7-f3e37d9ec464@linaro.org \
    --to=philmd@linaro.org \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).