From: Marek Vasut <marek.vasut@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Sven Schnelle" <svens@stackframe.org>,
"Prasad J Pandit" <pjp@fedoraproject.org>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH] net: tulip: Set PCI revision to match dec21143
Date: Sat, 6 Jun 2020 14:02:11 +0200 [thread overview]
Message-ID: <1b3ba4cf-d18a-08f8-b1b7-742434511c3f@gmail.com> (raw)
In-Reply-To: <20200418002552.343480-1-marek.vasut+renesas@gmail.com>
On 4/18/20 2:25 AM, Marek Vasut wrote:
> The tulip driver claims to emulate dec21143 and it does not emulate dec21142.
> The dec21142 and dec21143 can be discerned by the PCI revision register,
> where dec21142 reports value < 0x20 and dec21143 value >= 0x20. E.g. the
> U-Boot 'tulip' driver also only supports dec21143 and verifies that the
> PCI revision ID is >= 0x20, otherwise refuses to operate such a card.
>
> This patch sets the PCI revision ID to 0x20 to match the dec21143 and
> thus also permits e.g. U-Boot to work with the tulip emulation.
>
> Fixes: 34ea023d4b95 ("net: add tulip (dec21143) driver")
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Prasad J Pandit <pjp@fedoraproject.org>
> Cc: Sven Schnelle <svens@stackframe.org>
Bump, any news on this ? This is a bugfix.
next prev parent reply other threads:[~2020-06-06 12:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-18 0:25 [PATCH] net: tulip: Set PCI revision to match dec21143 Marek Vasut
2020-06-06 12:02 ` Marek Vasut [this message]
2020-06-07 22:17 ` Philippe Mathieu-Daudé
2020-06-10 21:13 ` Sven Schnelle
2020-06-10 22:27 ` Philippe Mathieu-Daudé
2020-06-10 22:39 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b3ba4cf-d18a-08f8-b1b7-742434511c3f@gmail.com \
--to=marek.vasut@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pjp@fedoraproject.org \
--cc=qemu-devel@nongnu.org \
--cc=svens@stackframe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).