From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Thomas Huth" <thuth@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH 2/2] tests: fix echi/ehci typo
Date: Thu, 26 Sep 2019 14:53:49 +0200 [thread overview]
Message-ID: <1b5ecf66-d7d1-e8d6-822c-6b0d8866aa0b@redhat.com> (raw)
In-Reply-To: <2283ca7e-15c4-ab3c-9fca-15207985ad64@redhat.com>
On 9/26/19 1:39 PM, Thomas Huth wrote:
> On 26/09/2019 13.19, Marc-André Lureau wrote:
>> While at it, simplify using $(land).
>>
>> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Fixes: dad5ddcea3b661c6b8ffd83b9bdf0c56001067a2
More than 1 year silently ignored, nice...
>
>> ---
>> tests/Makefile.include | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/tests/Makefile.include b/tests/Makefile.include
>> index 0595914526..3543451ed3 100644
>> --- a/tests/Makefile.include
>> +++ b/tests/Makefile.include
>> @@ -182,9 +182,7 @@ check-qtest-i386-$(CONFIG_PVPANIC) += tests/pvpanic-test$(EXESUF)
>> check-qtest-i386-$(CONFIG_I82801B11) += tests/i82801b11-test$(EXESUF)
>> check-qtest-i386-$(CONFIG_IOH3420) += tests/ioh3420-test$(EXESUF)
>> check-qtest-i386-$(CONFIG_USB_UHCI) += tests/usb-hcd-uhci-test$(EXESUF)
>> -ifeq ($(CONFIG_USB_ECHI)$(CONFIG_USB_UHCI),yy)
>
> D'oh!
:)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> -check-qtest-i386-y += tests/usb-hcd-ehci-test$(EXESUF)
>> -endif
>> +check-qtest-i386-$(call land,$(CONFIG_USB_EHCI),$(CONFIG_USB_UHCI)) += tests/usb-hcd-ehci-test$(EXESUF)
>> check-qtest-i386-$(CONFIG_USB_XHCI_NEC) += tests/usb-hcd-xhci-test$(EXESUF)
>> check-qtest-i386-y += tests/cpu-plug-test$(EXESUF)
>> check-qtest-i386-y += tests/q35-test$(EXESUF)
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
next prev parent reply other threads:[~2019-09-26 12:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 11:19 [PATCH 0/2] Fix ehci-test Marc-André Lureau
2019-09-26 11:19 ` [PATCH 1/2] tests: fix usb-hcd-ehci-test compilation Marc-André Lureau
2019-09-26 11:23 ` Laurent Vivier
2019-09-26 11:49 ` Thomas Huth
2019-09-26 11:19 ` [PATCH 2/2] tests: fix echi/ehci typo Marc-André Lureau
2019-09-26 11:24 ` Laurent Vivier
2019-09-26 11:39 ` Thomas Huth
2019-09-26 12:53 ` Philippe Mathieu-Daudé [this message]
2019-09-27 6:23 ` [PATCH 0/2] Fix ehci-test no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b5ecf66-d7d1-e8d6-822c-6b0d8866aa0b@redhat.com \
--to=philmd@redhat.com \
--cc=kraxel@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).