From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93C71CCA470 for ; Tue, 7 Oct 2025 04:19:38 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v5z9r-0001Yn-80; Tue, 07 Oct 2025 00:18:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v5z9p-0001YP-KK for qemu-devel@nongnu.org; Tue, 07 Oct 2025 00:18:37 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v5z9n-0002mP-Sq for qemu-devel@nongnu.org; Tue, 07 Oct 2025 00:18:37 -0400 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-46b303f7469so36398735e9.1 for ; Mon, 06 Oct 2025 21:18:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759810713; x=1760415513; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0ntoOjDf3YoDqQyd01IVuHNpp1dAxZUIRQ7d+2mqIJ0=; b=VxD3EMUGCvQzqAAooHgKdHv+HiWNuQZoepzVHzp0+rtH2TOSEG+Go+CINm8esjmAMn 2mEYqpsFCBa8KMUIxzCzRe8+fTtygoU7HGi7FtmDx71xwceNyYGH07DIQ+h+Bunsg6qz aXOmo1veQ7EjtLEhcHzHevek8wKZgjWXzrAii7laS0ngPp6TNbxlMxcK8UNtyGblC+cF fNqcNPnhl6bkhgo0VnwOyCY3hkf1UmSS4qAReGRHEUylcyiiIzTOvOxdsL9i6pB4NtP8 +2YjLWu9JpWYOzw8N8E1D8yO88zzYNutpUURoN4c4aOhYWPzs/fsUnU3KAmKpwGzyOT0 owKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759810713; x=1760415513; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0ntoOjDf3YoDqQyd01IVuHNpp1dAxZUIRQ7d+2mqIJ0=; b=u99790kt/GPfpT0WLsQdqsxdZZKFGlZRkD2MpxTeH3+2/e0LAiVSq+7UkdwYIDf6Nb 97uGor6E2WCDP4wBv5nlokoIJ0uDEtLECAkoFHdRhOEuJjDFRA4An9V59TU51HeFpgQQ mUp16aFE+v5acN23Ue07/nESNUKvr0fXnEIuOvp1O+AFMTF9IKFZy5K2FetfpouQkCMn cRKpY9poc6yEfkt+G7E8KO7afmlWFwfYyIaCxz/VfZzDmvz4NDUqdNqFK7HIPdU7TZuI e0FGQEbRvpP9M9a2zXIThw3M4usLqoTWVffAp2uKGnFmvzN+ERr0W7pRRswvriXvmvTi eE5g== X-Gm-Message-State: AOJu0YwNxkaxBuVnOl4KBxh0Pe82cpKOOUESAuXbFr+hHjbNLIJJPEn4 1YtKuFdzJYzqx3u1CtqLyiAWciGhtHrrMpWsE7OFxgV06WNgw8pgIdJlnDWUYRjaDc8= X-Gm-Gg: ASbGncsf8dcLSPPUSYwJTqd4uI68wJdOOXIJV/wXJx4WTLmc7MIfWtShNupcGLpg21d pDaRW4mg3wH2SXmdfoPU6cQq9fq0iB+QoQDuvUVtq6bSwoOV2gWS8YzgoILjHvrHFZNRp80tadA JMC3q1zWtVhX0k1VvV9xEAM4O9vX9zlC6RYRPQ20hGAVrZEgiulMpaZGzu59Kn19mpxZeZuHXwp ouV9D3HzZBULxBGn2py2hM/5CBEIzA9WMfqfJrxZ3g3HhkO/dDi8J9mUZm3hi7RCjpRvGKhfIyZ 53CnyJvCRnJFw1v0NNHH6gfwl19UexBkxjHMIlpzgBbqp43To/MHbA42QoxNdrmHeIK4a/zDNqo JwGrTzw71NTr34WRxDR0qvjs8enrmD2rRoaEffs6MOQwTSkFhL1kSkIFJnx27Uk/yihx6bAA2cA OabjLc2snA1C87TxZRb89QJHI= X-Google-Smtp-Source: AGHT+IGDAlw8peXRTxmbt0Dp91xBc8r3hdWlLYm3DcowMVLMmpP7BCA7xxiSkKgRVs+57f6H2tonLA== X-Received: by 2002:a05:600c:3556:b0:46e:4004:a296 with SMTP id 5b1f17b1804b1-46e71109df8mr105103335e9.9.1759810713028; Mon, 06 Oct 2025 21:18:33 -0700 (PDT) Received: from [192.168.69.221] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46fa3a0e89dsm8123995e9.3.2025.10.06.21.18.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Oct 2025 21:18:32 -0700 (PDT) Message-ID: <1b6204de-c54f-4ff4-82a4-863bb39378ea@linaro.org> Date: Tue, 7 Oct 2025 06:18:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 18/24] target/arm/hvf: Keep calling hv_vcpu_run() in loop Content-Language: en-US From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= To: Mads Ynddal Cc: qemu-devel@nongnu.org, Alexander Graf , Richard Henderson , qemu-arm@nongnu.org, Mohamed Mediouni , Peter Maydell , Phil Dennis-Jordan , Stefan Hajnoczi , Cameron Esfahani , Roman Bolshakov , Paolo Bonzini References: <20250903100702.16726-1-philmd@linaro.org> <20250903100702.16726-19-philmd@linaro.org> <1c196a68-0b97-4c60-ae42-9b3643cb1d72@linaro.org> In-Reply-To: <1c196a68-0b97-4c60-ae42-9b3643cb1d72@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 7/10/25 05:43, Philippe Mathieu-Daudé wrote: > On 8/9/25 14:26, Mads Ynddal wrote: >> >>> On 3 Sep 2025, at 12.06, Philippe Mathieu-Daudé >>> wrote: >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>> target/arm/hvf/hvf.c | 40 +++++++++++++++++++++------------------- >>> 1 file changed, 21 insertions(+), 19 deletions(-) >> >> It'd be nice with a commit message justifying the need for the change. I >> assume performance? > > Performance is a super positive side effect. Actually I had issues in > the outer vCPU loop because it is only aware of EXCP_* return values, > and the code handling unknown '0' retval is dubious. IOW I'd rather have > the outer loop assert for unknown values, as a programming error. (Also Richard later noted flush_cpu_state() should be called out of the inner loop).