From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5Gli-0008E6-Dy for qemu-devel@nongnu.org; Tue, 24 May 2016 14:09:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5Glh-0004sO-Dw for qemu-devel@nongnu.org; Tue, 24 May 2016 14:09:26 -0400 References: <1463470536-8981-1-git-send-email-famz@redhat.com> <1463470536-8981-16-git-send-email-famz@redhat.com> From: Max Reitz Message-ID: <1b65ee3c-cd91-f6fa-e720-c620804dd297@redhat.com> Date: Tue, 24 May 2016 20:09:16 +0200 MIME-Version: 1.0 In-Reply-To: <1463470536-8981-16-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7V7LrEV5EoWGk5LGQHWrBuC8Infs9bNJu" Subject: Re: [Qemu-devel] [PATCH v5 15/27] qemu-img: Update documentation of "-L" option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Jeff Cody , Markus Armbruster , Eric Blake , John Snow , qemu-block@nongnu.org, berrange@redhat.com, pbonzini@redhat.com, den@openvz.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7V7LrEV5EoWGk5LGQHWrBuC8Infs9bNJu From: Max Reitz To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Jeff Cody , Markus Armbruster , Eric Blake , John Snow , qemu-block@nongnu.org, berrange@redhat.com, pbonzini@redhat.com, den@openvz.org, stefanha@redhat.com Message-ID: <1b65ee3c-cd91-f6fa-e720-c620804dd297@redhat.com> Subject: Re: [PATCH v5 15/27] qemu-img: Update documentation of "-L" option References: <1463470536-8981-1-git-send-email-famz@redhat.com> <1463470536-8981-16-git-send-email-famz@redhat.com> In-Reply-To: <1463470536-8981-16-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 17.05.2016 09:35, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > qemu-img-cmds.hx | 44 ++++++++++++++++++++++---------------------- > qemu-img.c | 1 + > qemu-img.texi | 3 +++ > 3 files changed, 26 insertions(+), 22 deletions(-) >=20 [...] > diff --git a/qemu-img.texi b/qemu-img.texi > index afaebdd..b91f2e1 100644 > --- a/qemu-img.texi > +++ b/qemu-img.texi > @@ -77,6 +77,9 @@ progress is reported when the process receives a @cod= e{SIGUSR1} signal. > @item -q > Quiet mode - do not print any output (except errors). There's no progr= ess bar > in case both @var{-q} and @var{-p} options are used. > +@item -L > +disables image locking. The image will not be locked, other processes = can > +access and lock this image while we are using it. I think "while it is in use by qemu-img" sounds more program-y. Other than that, the patch is OK unless you decide that indeed two distinct flags for source and target make sense for convert and rebase. Max > @item -S @var{size} > indicates the consecutive number of bytes that must contain only zeros= > for qemu-img to create a sparse image during conversion. This value is= rounded >=20 --7V7LrEV5EoWGk5LGQHWrBuC8Infs9bNJu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXRJjMAAoJEDuxQgLoOKytZbYIAIF8Dd+rJwW4wSmzRxfGfWgw XqNj3lP3wkRHVJRMYa1cM4y9Bz0LPAd5olxLhyxeFRLKkPKZBoB7ATieZ9qbjSlu J2z0lkvA+/bBqWriADtJsfT2ISy9FBqlHDzc/kNLgLd5xRdMMgIPo3k9W9X5Nm5z LGZKmZKKukgyQsVmn44Ux/URhM2VohMfZR0cKx6ASQYZNUAVDwrV6WKeF6GNRDd1 a2s++27N6XKYWwKsg0iidSV0qcvFHHHldE8bDBytoY+l05IvsU3x5Dc7aobcnjs/ VW4IMQHpNPCWIEijv1qZ99gdwFxt1GkjKJNLhvc7BaAgD8g+rP7GVI9DjBsb98o= =gqJI -----END PGP SIGNATURE----- --7V7LrEV5EoWGk5LGQHWrBuC8Infs9bNJu--