qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/3] ahci: fix completion race condition
Date: Thu, 31 May 2018 20:00:34 -0400	[thread overview]
Message-ID: <1b6be0a7-9420-0cf7-63f8-0cd124873d96@redhat.com> (raw)
In-Reply-To: <20180531004323.4611-1-jsnow@redhat.com>



On 05/30/2018 08:43 PM, John Snow wrote:
> Commit d759c951f changed the main thread lock release/reacquisition,
> and in so doing apparently jostled loose a race condition in the AHCI
> code.
> 
> Patch 2 should be sufficient to fix this, and patches 1 and 3 are just
> little trivial fixes.
> 
> This might be sufficient to fix the bug as reported at
> https://bugs.launchpad.net/qemu/+bug/1769189
> but the nature of the timing changes make it difficult to confirm,
> so I am posting this patchset for the reporters to help test.
> 
> John Snow (3):
>   ahci: trim signatures on raise/lower
>   ahci: fix PxCI register race
>   ahci: don't schedule unnecessary BH
> 
>  hw/ide/ahci.c | 24 +++++++++++-------------
>  1 file changed, 11 insertions(+), 13 deletions(-)
> 

Thanks for the testing and reviews, everyone!

Thanks, applied to my IDE tree:

https://github.com/jnsnow/qemu/commits/ide
https://github.com/jnsnow/qemu.git

--js

  parent reply	other threads:[~2018-06-01  0:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-31  0:43 [Qemu-devel] [PATCH 0/3] ahci: fix completion race condition John Snow
2018-05-31  0:43 ` [Qemu-devel] [PATCH 1/3] ahci: trim signatures on raise/lower John Snow
2018-05-31 14:56   ` Eric Blake
2018-05-31 15:38     ` John Snow
2018-05-31 16:00   ` [Qemu-devel] [Qemu-block] " Jeff Cody
2018-05-31  0:43 ` [Qemu-devel] [PATCH 2/3] ahci: fix PxCI register race John Snow
2018-05-31 16:16   ` John Snow
2018-05-31 16:22   ` [Qemu-devel] [Qemu-block] " Jeff Cody
2018-05-31  0:43 ` [Qemu-devel] [PATCH 3/3] ahci: don't schedule unnecessary BH John Snow
2018-05-31 16:22   ` [Qemu-devel] [Qemu-block] " Jeff Cody
2018-05-31  8:01 ` [Qemu-devel] [Qemu-block] [PATCH 0/3] ahci: fix completion race condition Stefan Hajnoczi
2018-05-31 12:21 ` [Qemu-devel] " Bruce Rogers
2018-05-31 13:06   ` Philippe Mathieu-Daudé
2018-05-31 13:12     ` Bruce Rogers
2018-06-01  0:00 ` John Snow [this message]
2018-06-04  9:22   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b6be0a7-9420-0cf7-63f8-0cd124873d96@redhat.com \
    --to=jsnow@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).