From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51400) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fOXUp-00081Z-7H for qemu-devel@nongnu.org; Thu, 31 May 2018 20:00:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fOXUo-0008To-8c for qemu-devel@nongnu.org; Thu, 31 May 2018 20:00:43 -0400 References: <20180531004323.4611-1-jsnow@redhat.com> From: John Snow Message-ID: <1b6be0a7-9420-0cf7-63f8-0cd124873d96@redhat.com> Date: Thu, 31 May 2018 20:00:34 -0400 MIME-Version: 1.0 In-Reply-To: <20180531004323.4611-1-jsnow@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] ahci: fix completion race condition List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, qemu-block@nongnu.org On 05/30/2018 08:43 PM, John Snow wrote: > Commit d759c951f changed the main thread lock release/reacquisition, > and in so doing apparently jostled loose a race condition in the AHCI > code. > > Patch 2 should be sufficient to fix this, and patches 1 and 3 are just > little trivial fixes. > > This might be sufficient to fix the bug as reported at > https://bugs.launchpad.net/qemu/+bug/1769189 > but the nature of the timing changes make it difficult to confirm, > so I am posting this patchset for the reporters to help test. > > John Snow (3): > ahci: trim signatures on raise/lower > ahci: fix PxCI register race > ahci: don't schedule unnecessary BH > > hw/ide/ahci.c | 24 +++++++++++------------- > 1 file changed, 11 insertions(+), 13 deletions(-) > Thanks for the testing and reviews, everyone! Thanks, applied to my IDE tree: https://github.com/jnsnow/qemu/commits/ide https://github.com/jnsnow/qemu.git --js