From: Eric Blake <eblake@redhat.com>
To: Andrew Baumann <Andrew.Baumann@microsoft.com>, qemu-devel@nongnu.org
Cc: Stefan Weil <sw@weilnetz.de>, "Michael S . Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.9 v2] virtio: fix vring_align() on 64-bit win32 platforms
Date: Fri, 24 Mar 2017 17:20:00 -0500 [thread overview]
Message-ID: <1b72685e-c176-82f1-a540-c2e317f5374f@redhat.com> (raw)
In-Reply-To: <20170324212115.6772-1-Andrew.Baumann@microsoft.com>
[-- Attachment #1: Type: text/plain, Size: 646 bytes --]
On 03/24/2017 04:21 PM, Andrew Baumann wrote:
So is 'win32' really a 64-bit platform, or should the subject be '64-bit
windows'?
> long is 32-bits on win32, which caused the top half of the address to
> be truncated; this patch changes it to use the QEMU_ALIGN_UP macro
> which does not suffer the same problem
>
> Signed-off-by: Andrew Baumann <Andrew.Baumann@microsoft.com>
> ---
> include/hw/virtio/virtio.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-03-24 22:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 21:21 [Qemu-devel] [PATCH v2] virtio: fix vring_align() on 64-bit win32 platforms Andrew Baumann
2017-03-24 22:20 ` Eric Blake [this message]
2017-03-24 23:11 ` [Qemu-devel] [PATCH for-2.9 " Andrew Baumann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b72685e-c176-82f1-a540-c2e317f5374f@redhat.com \
--to=eblake@redhat.com \
--cc=Andrew.Baumann@microsoft.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).