From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AB3EC0018C for ; Wed, 16 Dec 2020 18:16:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1052725BB4 for ; Wed, 16 Dec 2020 18:16:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1052725BB4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpbLV-00010q-O2 for qemu-devel@archiver.kernel.org; Wed, 16 Dec 2020 13:16:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpbKS-0000NL-4V for qemu-devel@nongnu.org; Wed, 16 Dec 2020 13:15:12 -0500 Received: from mail-oo1-xc35.google.com ([2607:f8b0:4864:20::c35]:44140) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kpbKP-0007oL-WD for qemu-devel@nongnu.org; Wed, 16 Dec 2020 13:15:11 -0500 Received: by mail-oo1-xc35.google.com with SMTP id j21so3370407oou.11 for ; Wed, 16 Dec 2020 10:15:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=IYGqEzGvLPinqxet7fLCq07VlJlFvaKQthIt0Lqwapg=; b=e8+3OaV7gH11dAp8J9Dtx9GzL5BxAKvASRJXUJZAqpPa8BO2zhgJN6+w32951bnGO4 ZDO7T4UyKjvRjvPCh0GVoyliHgtPMmooiWOo++6DF0RLnHeBPPEF5uLE1rMYeMEeLMCd ZqJBfOjW9fMmV8HgiwdJaGNti6ciCAzJDzSH6+ytQJ1rEExB9sOVzDsgy6vLSah+IGju BRaMZO1q+Hq9xk+hp58pab6Gz0l6Xi8ksTqWN7CrUJlXmRZlgEeKBMnjO7opiztrqQ25 WNCjyTaRmqeX7pQJVIjXvlTqb2SxFnCRnuBP/kvCZggpRe/hkOZkWQeieVUOVwt1uiX7 dmCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IYGqEzGvLPinqxet7fLCq07VlJlFvaKQthIt0Lqwapg=; b=bKNRgr3vyc0+7kLb6+Ovg2VIThrtZJ/HATp/uA3ivJ99UjRqDBU6x580YE3TtL17B4 Xd0QMSo+zJovkJVpuiHsuZFzW5eAh7qx/O2NIcW0Vh+f+HCF5fB89b3b69rGh0qB498K ufGHIUWWlc5dUsNVF+8GtVHcU3CNRVTBBw0Y6oKDrTzrRzkaDE6m994z9xbn/1VuPxeK /YQCm0z4C2MzpscQx0OMWevrGuB64i1gdnqDsVfuAS8tesB5ECF3PW6XarIns4Gl/aiL T2Odh+T2KjMKd0mrWCRYymhyTiDCn5IHZ3qOxUsUAtxgxAgBoRdX+LJWRn5IvqNYdGC1 +XaQ== X-Gm-Message-State: AOAM531fhAcHZGCz3Mvafpbp7D/nw1HuR9UBgCRyGlWw6zzAkb3OrzTR gjlxHRj+fNP1Eds8nAnbOaVmDQ== X-Google-Smtp-Source: ABdhPJxg8rEEWvYmNKj2NWXBrEpP+7roH5K0OO3dxatjrda7JFgYun2yC8IOqbUEpygJeQ0ILmWZ5A== X-Received: by 2002:a4a:c4c7:: with SMTP id g7mr25901087ooq.50.1608142508689; Wed, 16 Dec 2020 10:15:08 -0800 (PST) Received: from [10.10.121.52] (fixed-187-189-51-144.totalplay.net. [187.189.51.144]) by smtp.gmail.com with ESMTPSA id 11sm596393oty.65.2020.12.16.10.15.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Dec 2020 10:15:07 -0800 (PST) Subject: Re: [RFC v2 12/15] target/riscv: rvb: generalized or-combine To: frank.chang@sifive.com, qemu-devel@nongnu.org, qemu-riscv@nongnu.org References: <20201216020150.3157-1-frank.chang@sifive.com> <20201216020150.3157-13-frank.chang@sifive.com> From: Richard Henderson Message-ID: <1b81661c-58f5-0ead-8e9f-4fefbf538e46@linaro.org> Date: Wed, 16 Dec 2020 12:15:05 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201216020150.3157-13-frank.chang@sifive.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::c35; envelope-from=richard.henderson@linaro.org; helo=mail-oo1-xc35.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastian Koppelmann , Kito Cheng , Alistair Francis , Palmer Dabbelt , Sagar Karandikar Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/15/20 8:01 PM, frank.chang@sifive.com wrote: > +static bool trans_gorci(DisasContext *ctx, arg_gorci *a) > +{ > + REQUIRE_EXT(ctx, RVB); > + > + if (a->shamt >= TARGET_LONG_BITS) { > + return false; > + } Check should be in gen_shifti. > +static bool trans_gorciw(DisasContext *ctx, arg_gorciw *a) > +{ > + REQUIRE_EXT(ctx, RVB); > + > + if (a->shamt >= 32) { > + return false; > + } Check is unnecessary due to @sh5. > +static void gen_gorcw(TCGv ret, TCGv arg1, TCGv arg2) > +{ > + tcg_gen_ext32u_tl(arg1, arg1); > + gen_helper_gorc(ret, arg1, arg2); > +} Calling the wrong helper. The zero-extension should be unnecessary -- the high bits will be overridden by the sign-extension at the end of gen_shiftw. r~