From: "Denis V. Lunev" <den@openvz.org>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Fam Zheng <famz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-block@nongnu.org, qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/1] block: fix possible return code clobbering in bdrv_co_pdiscard
Date: Mon, 10 Jul 2017 17:31:00 +0300 [thread overview]
Message-ID: <1b8afbef-5c44-d81a-68d2-52e239b7e46f@openvz.org> (raw)
In-Reply-To: <bb92a87e-193a-9f61-38c5-ee69fcff2a97@redhat.com>
On 07/10/2017 04:51 PM, Eric Blake wrote:
> On 07/10/2017 03:35 AM, Denis V. Lunev wrote:
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> CC: Stefan Hajnoczi <stefanha@redhat.com> (supporter:Block I/O path)
>> CC: Fam Zheng <famz@redhat.com> (supporter:Block I/O path)
> The commit message is a bit sparse; I might have written:
>
> block: fix shadowed variable in bdrv_co_pdiscard
>
> We've had a shadowed 'ret' variable, which risks returning the wrong
> value, introduced in commit b9c64947.
thank you for the proposal.
Den
next prev parent reply other threads:[~2017-07-10 14:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 8:35 [Qemu-devel] [PATCH 1/1] block: fix possible return code clobbering in bdrv_co_pdiscard Denis V. Lunev
2017-07-10 8:56 ` Fam Zheng
2017-07-10 8:59 ` Denis V. Lunev
2017-07-10 13:51 ` Eric Blake
2017-07-10 14:31 ` Denis V. Lunev [this message]
2017-07-10 13:59 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
2017-07-10 14:31 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b8afbef-5c44-d81a-68d2-52e239b7e46f@openvz.org \
--to=den@openvz.org \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).