From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUZiq-0000XI-Q3 for qemu-devel@nongnu.org; Mon, 10 Jul 2017 10:31:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUZip-0007PH-WB for qemu-devel@nongnu.org; Mon, 10 Jul 2017 10:31:36 -0400 References: <20170710083553.6167-1-den@openvz.org> From: "Denis V. Lunev" Message-ID: <1b8afbef-5c44-d81a-68d2-52e239b7e46f@openvz.org> Date: Mon, 10 Jul 2017 17:31:00 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US Subject: Re: [Qemu-devel] [PATCH 1/1] block: fix possible return code clobbering in bdrv_co_pdiscard List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: Fam Zheng , Stefan Hajnoczi , qemu-block@nongnu.org, qemu-stable On 07/10/2017 04:51 PM, Eric Blake wrote: > On 07/10/2017 03:35 AM, Denis V. Lunev wrote: >> Signed-off-by: Denis V. Lunev >> CC: Stefan Hajnoczi (supporter:Block I/O path) >> CC: Fam Zheng (supporter:Block I/O path) > The commit message is a bit sparse; I might have written: > > block: fix shadowed variable in bdrv_co_pdiscard > > We've had a shadowed 'ret' variable, which risks returning the wrong > value, introduced in commit b9c64947. thank you for the proposal. Den