From: Matthew Rosato <mjrosato@linux.ibm.com>
To: Eric Farman <farman@linux.ibm.com>, qemu-s390x@nongnu.org
Cc: thuth@redhat.com, clg@redhat.com, frankja@linux.ibm.com,
pasic@linux.ibm.com, borntraeger@linux.ibm.com,
richard.henderson@linaro.org, david@redhat.com,
iii@linux.ibm.com, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/3] s390x/pci: avoid double enable/disable of aif
Date: Wed, 17 Jan 2024 10:06:53 -0500 [thread overview]
Message-ID: <1b8f18fe-7baf-4358-871d-be8db51e1d84@linux.ibm.com> (raw)
In-Reply-To: <0369e3381ec73d7fd5a34d2d9e36f98dde829cb5.camel@linux.ibm.com>
>> - return kvm_vm_ioctl(kvm_state, KVM_S390_ZPCI_OP, &args);
>> + if (!pbdev->aif) {
>> + return -EINVAL;
>> + }
>> +
>> + rc = kvm_vm_ioctl(kvm_state, KVM_S390_ZPCI_OP, &args);
>> + if (rc == 0) {
>> + pbev->aif = false;
>
> s/pbev/pbdev/
>
> You fix this in patch 2. :)
>
Oops, thanks for catching that.
next prev parent reply other threads:[~2024-01-17 15:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 22:31 [PATCH 0/3] s390x/pci: fix ISM reset Matthew Rosato
2024-01-16 22:31 ` [PATCH 1/3] s390x/pci: avoid double enable/disable of aif Matthew Rosato
2024-01-17 1:57 ` Eric Farman
2024-01-17 15:06 ` Matthew Rosato [this message]
2024-01-17 10:54 ` Cédric Le Goater
2024-01-17 15:11 ` Matthew Rosato
2024-01-16 22:31 ` [PATCH 2/3] s390x/pci: refresh fh before disabling aif Matthew Rosato
2024-01-17 2:01 ` Eric Farman
2024-01-17 10:31 ` Cédric Le Goater
2024-01-17 15:07 ` Matthew Rosato
2024-01-17 10:40 ` Cédric Le Goater
2024-01-17 15:17 ` Matthew Rosato
2024-01-16 22:31 ` [PATCH 3/3] s390x/pci: drive ISM reset from subsystem reset Matthew Rosato
2024-01-17 3:01 ` Eric Farman
2024-01-17 15:07 ` Matthew Rosato
2024-01-17 11:01 ` Cédric Le Goater
2024-01-17 15:19 ` Matthew Rosato
2024-01-17 21:11 ` Matthew Rosato
2024-01-18 7:02 ` Cédric Le Goater
2024-01-18 6:03 ` [PATCH 0/3] s390x/pci: fix ISM reset Michael Tokarev
2024-01-18 7:19 ` Thomas Huth
2024-01-18 7:37 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b8f18fe-7baf-4358-871d-be8db51e1d84@linux.ibm.com \
--to=mjrosato@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=clg@redhat.com \
--cc=david@redhat.com \
--cc=farman@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).