From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACFA8C47258 for ; Wed, 17 Jan 2024 15:07:53 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQ7VZ-0008N5-Ae; Wed, 17 Jan 2024 10:07:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQ7VQ-0008Mf-8x; Wed, 17 Jan 2024 10:07:04 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQ7VN-0004aD-FP; Wed, 17 Jan 2024 10:07:03 -0500 Received: from pps.filterd (m0353728.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 40HEVCB9012923; Wed, 17 Jan 2024 15:06:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=Om5v1btbEcb1yDdXt8nepHwcscosscG6ArHucx96b4Q=; b=s8YCnr3Rc07Rriyek9uepNCLl7Em7pc7zXqU8DpRnmMU014M/Jd1nNZdWxzfU2dmqDtY 1XgOE59qP6m9DBa1pLYKgMN9ERY5lGiEbxd6rLGjNnaE4bV6pBa2cUwjLRT+XrFt7x3u SHr2HJiGGcvnA9LSZ8qtI9kaqELL8TTADOW3emgF1NemUvgt+zqMWCuiIe/a3lHD0fGg WP0n67Yt8ATMXUMI56YFu61+0u3b8O4ZRFE1Asd7i4WH4VCFZuAZCGGRqhCmWf/o/qfr dxyOpj+kceDsiiMxdXtCCvJe1dXXipaQiJzm6EVRv3nkTV0i3tjd4i4XbFUjLl56/Dx1 zA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vpgcj22xx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 Jan 2024 15:06:57 +0000 Received: from m0353728.ppops.net (m0353728.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 40HEu9Es005247; Wed, 17 Jan 2024 15:06:57 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vpgcj22w7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 Jan 2024 15:06:56 +0000 Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 40HEQl1Q008530; Wed, 17 Jan 2024 15:06:55 GMT Received: from smtprelay07.dal12v.mail.ibm.com ([172.16.1.9]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3vm5unp0tg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 Jan 2024 15:06:55 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay07.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 40HF6sGi48104002 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Jan 2024 15:06:54 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6752158056; Wed, 17 Jan 2024 15:06:54 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9765F5803F; Wed, 17 Jan 2024 15:06:53 +0000 (GMT) Received: from [9.61.163.245] (unknown [9.61.163.245]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Wed, 17 Jan 2024 15:06:53 +0000 (GMT) Message-ID: <1b8f18fe-7baf-4358-871d-be8db51e1d84@linux.ibm.com> Date: Wed, 17 Jan 2024 10:06:53 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] s390x/pci: avoid double enable/disable of aif To: Eric Farman , qemu-s390x@nongnu.org Cc: thuth@redhat.com, clg@redhat.com, frankja@linux.ibm.com, pasic@linux.ibm.com, borntraeger@linux.ibm.com, richard.henderson@linaro.org, david@redhat.com, iii@linux.ibm.com, qemu-devel@nongnu.org References: <20240116223157.73752-1-mjrosato@linux.ibm.com> <20240116223157.73752-2-mjrosato@linux.ibm.com> <0369e3381ec73d7fd5a34d2d9e36f98dde829cb5.camel@linux.ibm.com> Content-Language: en-US From: Matthew Rosato In-Reply-To: <0369e3381ec73d7fd5a34d2d9e36f98dde829cb5.camel@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: OkMqPke-4tAEs8OibY6_FAZ4qX2v3oVg X-Proofpoint-GUID: 6O7CN_Qi2AekIwHeiALLFykQo_Pp8JsF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-17_08,2024-01-17_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 phishscore=0 impostorscore=0 mlxlogscore=433 adultscore=0 mlxscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401170109 Received-SPF: pass client-ip=148.163.156.1; envelope-from=mjrosato@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org >> -    return kvm_vm_ioctl(kvm_state, KVM_S390_ZPCI_OP, &args); >> +    if (!pbdev->aif) { >> +        return -EINVAL; >> +    } >> + >> +    rc = kvm_vm_ioctl(kvm_state, KVM_S390_ZPCI_OP, &args); >> +    if (rc == 0) { >> +        pbev->aif = false; > > s/pbev/pbdev/ > > You fix this in patch 2. :) > Oops, thanks for catching that.