From: Eric Blake <eblake@redhat.com>
To: Unai Martinez-Corral <unai.martinezcorral@ehu.eus>,
qemu-devel@nongnu.org
Cc: riku.voipio@iki.fi, laurent@vivier.eu
Subject: Re: [PATCH v8 1/9] qemu-binfmt-conf.sh: enforce safe style consistency
Date: Mon, 9 Mar 2020 10:01:10 -0500 [thread overview]
Message-ID: <1ba522c6-cae8-9e1f-ebf4-696076d2ca45@redhat.com> (raw)
In-Reply-To: <20200307172248.GA9@afee69d503a7>
On 3/7/20 11:22 AM, Unai Martinez-Corral wrote:
> Spaces are added before '; then', for consistency.
For consistency with what? This is not our prevailing style; as
evidenced by this pre-patch search:
$ git grep 'if \[.*\];' | wc
274 2186 18170
$ git grep 'if \[.*\] ;' | wc
25 256 1573
and you are diverging from the dominant pattern.
>
> All the tests are prefixed with 'x', in order to avoid risky comparisons
> (i.e. a user deliberately trying to provoke a syntax error).
This part, however, is good. Since one part is controversial, you may
want to split this into two patches, or even drop the reformatting part.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-03-09 15:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-07 17:22 [PATCH v8 1/9] qemu-binfmt-conf.sh: enforce safe style consistency Unai Martinez-Corral
2020-03-09 15:01 ` Eric Blake [this message]
2020-03-09 18:20 ` Unai Martinez Corral
2020-03-09 18:32 ` Eric Blake
-- strict thread matches above, loose matches on Subject: below --
2020-03-07 17:04 [PATCH v8 0/9] qemu-binfmt-conf.sh unai.martinezcorral
2020-03-07 18:38 ` [PATCH v8 1/9] qemu-binfmt-conf.sh: enforce safe style consistency Unai Martinez-Corral
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ba522c6-cae8-9e1f-ebf4-696076d2ca45@redhat.com \
--to=eblake@redhat.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=unai.martinezcorral@ehu.eus \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).