Re: [Qemu-devel] [PATCH v2] tpm: move qdev_prop_tpm to hw/tpm/

[Stefan Berger <stefanb@linux.vnet.ibm.com>]

On 12/18/2017 02:40 PM, Laurent Vivier wrote:
> On 18/12/2017 19:36, Cornelia Huck wrote:
>> Building with --disable-tpm yields
>>
>> ../hw/core/qdev-properties-system.o: In function `set_tpm':
>> /home/cohuck/git/qemu/hw/core/qdev-properties-system.c:274: undefined reference to `qemu_find_tpm_be'
>> /home/cohuck/git/qemu/hw/core/qdev-properties-system.c:278: undefined reference to `tpm_backend_init'
>> ../hw/core/qdev-properties-system.o: In function `release_tpm':
>> /home/cohuck/git/qemu/hw/core/qdev-properties-system.c:291: undefined reference to `tpm_backend_reset'
>>
>> Move the implementation of DEFINE_PROP_TPMBE to hw/tpm/ so that it is
>> only built when tpm is actually configured, and build tpm_util in every
>> case.
>>
>> Fixes: 493b78303532 ("qdev: add DEFINE_PROP_TPMBE")
>> Reported-by: Thomas Huth <thuth@redhat.com>
>> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
>> ---
>> v1->v2: fix x86_64 build with mingw (always build tpm_util)
>> ---
>>   hw/core/qdev-properties-system.c | 64 --------------------------------------
>>   hw/tpm/Makefile.objs             |  5 +--
>>   hw/tpm/tpm_util.c                | 67 ++++++++++++++++++++++++++++++++++++++++
>>   hw/tpm/tpm_util.h                |  3 ++
>>   include/hw/qdev-properties.h     |  2 --
>>   5 files changed, 73 insertions(+), 68 deletions(-)
>>
> Reviewed-by: Laurent Vivier <lvivier@redhat.com>
>
>
>
Thanks. Preparing a pull request for tomorrow.

     Stefan