From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48171) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eR1kc-0004LX-Km for qemu-devel@nongnu.org; Mon, 18 Dec 2017 15:11:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eR1kN-0000QZ-7Z for qemu-devel@nongnu.org; Mon, 18 Dec 2017 15:11:02 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:38396 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eR1kN-0000QG-2L for qemu-devel@nongnu.org; Mon, 18 Dec 2017 15:10:47 -0500 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id vBIK9avb033051 for ; Mon, 18 Dec 2017 15:10:44 -0500 Received: from e15.ny.us.ibm.com (e15.ny.us.ibm.com [129.33.205.205]) by mx0b-001b2d01.pphosted.com with ESMTP id 2exkbf2qyk-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 18 Dec 2017 15:10:43 -0500 Received: from localhost by e15.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 18 Dec 2017 15:10:43 -0500 References: <20171218183631.32357-1-cohuck@redhat.com> From: Stefan Berger Date: Mon, 18 Dec 2017 15:10:38 -0500 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Message-Id: <1bb44350-bb7b-86a9-cc7c-8ddde2419629@linux.vnet.ibm.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] tpm: move qdev_prop_tpm to hw/tpm/ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier , Cornelia Huck , pbonzini@redhat.com Cc: marcandre.lureau@redhat.com, thuth@redhat.com, qemu-devel@nongnu.org, f4bug@amsat.org On 12/18/2017 02:40 PM, Laurent Vivier wrote: > On 18/12/2017 19:36, Cornelia Huck wrote: >> Building with --disable-tpm yields >> >> ../hw/core/qdev-properties-system.o: In function `set_tpm': >> /home/cohuck/git/qemu/hw/core/qdev-properties-system.c:274: undefined = reference to `qemu_find_tpm_be' >> /home/cohuck/git/qemu/hw/core/qdev-properties-system.c:278: undefined = reference to `tpm_backend_init' >> ../hw/core/qdev-properties-system.o: In function `release_tpm': >> /home/cohuck/git/qemu/hw/core/qdev-properties-system.c:291: undefined = reference to `tpm_backend_reset' >> >> Move the implementation of DEFINE_PROP_TPMBE to hw/tpm/ so that it is >> only built when tpm is actually configured, and build tpm_util in ever= y >> case. >> >> Fixes: 493b78303532 ("qdev: add DEFINE_PROP_TPMBE") >> Reported-by: Thomas Huth >> Reviewed-by: Marc-Andr=C3=A9 Lureau >> Signed-off-by: Cornelia Huck >> --- >> v1->v2: fix x86_64 build with mingw (always build tpm_util) >> --- >> hw/core/qdev-properties-system.c | 64 ------------------------------= -------- >> hw/tpm/Makefile.objs | 5 +-- >> hw/tpm/tpm_util.c | 67 ++++++++++++++++++++++++++++++= ++++++++++ >> hw/tpm/tpm_util.h | 3 ++ >> include/hw/qdev-properties.h | 2 -- >> 5 files changed, 73 insertions(+), 68 deletions(-) >> > Reviewed-by: Laurent Vivier > > > Thanks. Preparing a pull request for tomorrow. Stefan