qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Greg Kurz <groug@kaod.org>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [PATCH] Makefile: Ensure cscope.out/tags/TAGS are generated in the source tree
Date: Thu, 15 Oct 2020 17:06:26 +0200	[thread overview]
Message-ID: <1bb86de1-75b3-be22-0363-505363478ada@redhat.com> (raw)
In-Reply-To: <160277334665.1754102.10921580280105870386.stgit@bahia.lan>

On 15/10/20 16:49, Greg Kurz wrote:
> Tools usually expect the index files to be in the source tree, eg. emacs.
> This is already the case when doing out-of-tree builds, but with in-tree
> builds they end up in the build directory.
> 
> Force cscope, ctags and etags to put them in the source tree.
> 
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
>  Makefile |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 3c5a0b0f7a11..45f983d9ef08 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -194,19 +194,19 @@ find-src-path = find "$(SRC_PATH)/" -path "$(SRC_PATH)/meson" -prune -o \( -name
>  
>  .PHONY: ctags
>  ctags:
> -	rm -f tags
> -	$(find-src-path) -exec ctags --append {} +
> +	rm -f "$(SRC_PATH)/"tags
> +	$(find-src-path) -exec ctags -f "$(SRC_PATH)/"tags --append {} +
>  
>  .PHONY: TAGS
>  TAGS:
> -	rm -f TAGS
> -	$(find-src-path) -exec etags --append {} +
> +	rm -f "$(SRC_PATH)/"TAGS
> +	$(find-src-path) -exec etags -f "$(SRC_PATH)/"TAGS --append {} +
>  
>  .PHONY: cscope
>  cscope:
>  	rm -f "$(SRC_PATH)"/cscope.*
>  	$(find-src-path) -print | sed -e 's,^\./,,' > "$(SRC_PATH)/cscope.files"
> -	cscope -b -i"$(SRC_PATH)/cscope.files"
> +	cscope -b -i"$(SRC_PATH)/cscope.files" -f"$(SRC_PATH)"/cscope.out
>  
>  # Needed by "meson install"
>  export DESTDIR
> 
> 

Queued, thanks.

Paolo



      reply	other threads:[~2020-10-15 15:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15 14:49 [PATCH] Makefile: Ensure cscope.out/tags/TAGS are generated in the source tree Greg Kurz
2020-10-15 15:06 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1bb86de1-75b3-be22-0363-505363478ada@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=groug@kaod.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).