From: Eric Blake <eblake@redhat.com>
To: John Snow <jsnow@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
vsementov@virtuozzo.com, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] blockdev: abort transactions in reverse order
Date: Thu, 6 Dec 2018 14:37:28 -0600 [thread overview]
Message-ID: <1bba0107-89d3-eb83-b242-9faebaac3ec4@redhat.com> (raw)
In-Reply-To: <20181206192544.3987-2-jsnow@redhat.com>
On 12/6/18 1:25 PM, John Snow wrote:
> Presently, we abort transactions in the same order they were processed in.
> Bitmap commands, though, attempt to restore backup data structures on abort.
> To that end, though, they need to be aborted in reverse chronological order.
>
> Replace the QSIMPLEQ data structure with a QTAILQ one, so we can iterate
> in reverse for the abort phase of the transaction.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> blockdev.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
Does this need to cc qemu-stable? I'm trying to figure out if it affects
any of the transactions issued by my libvirt code demo'd at KVM Forum.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-12-06 20:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 19:25 [Qemu-devel] [PATCH 0/3] bitmaps: remove x- prefix from QMP api John Snow
2018-12-06 19:25 ` [Qemu-devel] [PATCH 1/3] blockdev: abort transactions in reverse order John Snow
2018-12-06 20:37 ` Eric Blake [this message]
2018-12-06 20:43 ` John Snow
2018-12-07 8:38 ` Vladimir Sementsov-Ogievskiy
2018-12-06 19:25 ` [Qemu-devel] [PATCH 2/3] blockdev: n-ary bitmap merge John Snow
2018-12-07 16:25 ` Eric Blake
2018-12-11 23:05 ` John Snow
2018-12-06 19:25 ` [Qemu-devel] [PATCH 3/3] block: remove 'x' prefix from experimental bitmap APIs John Snow
2018-12-07 16:28 ` Eric Blake
2018-12-11 22:55 ` John Snow
2018-12-06 20:39 ` [Qemu-devel] [PATCH 0/3] bitmaps: remove x- prefix from QMP api John Snow
2018-12-07 0:08 ` no-reply
2018-12-11 23:08 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bba0107-89d3-eb83-b242-9faebaac3ec4@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).