qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Beraldo Leal" <bleal@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH] gitlab-ci: Replace build_script -> step_script in Cirrus jobs
Date: Mon, 19 Aug 2024 07:38:37 +0200	[thread overview]
Message-ID: <1bc0a966-e000-46a2-bea6-99f579600d74@redhat.com> (raw)
In-Reply-To: <20240816213203.18350-1-philmd@linaro.org>

On 16/08/2024 23.32, Philippe Mathieu-Daudé wrote:
> Long due upgrade, see [1]:
> 
>    In GitLab Runner 13.2 a translation for step_script to
>    build_script was added to the custom executor. In 14.0
>    the build_script stage will be replaced with step_script.
> 
> We are using GitLab 17 [2]!
> 
> This removes the following warning:
> 
>    WARNING: Starting with version 17.0 the 'build_script'
>    stage will be replaced with 'step_script':
>    https://gitlab.com/groups/gitlab-org/-/epics/6112
> 
> [1] https://about.gitlab.com/releases/2021/05/22/gitlab-13-12-released/#remove-translation-from-stepscript-to-buildscript-in-custom-executor
> [2] https://about.gitlab.com/releases/2024/05/16/gitlab-17-0-released/
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   .gitlab-ci.d/cirrus/build.yml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.gitlab-ci.d/cirrus/build.yml b/.gitlab-ci.d/cirrus/build.yml
> index 43dd52dd19..102cdbd8b1 100644
> --- a/.gitlab-ci.d/cirrus/build.yml
> +++ b/.gitlab-ci.d/cirrus/build.yml
> @@ -26,7 +26,7 @@ build_task:
>       - git clone --depth 100 "$CI_REPOSITORY_URL" .
>       - git fetch origin "$CI_COMMIT_REF_NAME"
>       - git reset --hard "$CI_COMMIT_SHA"
> -  build_script:
> +  step_script:
>       - mkdir build
>       - cd build
>       - ../configure --enable-werror $CONFIGURE_ARGS

Reviewed-by: Thomas Huth <thuth@redhat.com>



      reply	other threads:[~2024-08-19  5:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-16 21:32 [PATCH] gitlab-ci: Replace build_script -> step_script in Cirrus jobs Philippe Mathieu-Daudé
2024-08-19  5:38 ` Thomas Huth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1bc0a966-e000-46a2-bea6-99f579600d74@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=bleal@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).