From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Daniel P. Berrange" <berrange@redhat.com>,
qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: Infinite loop in bus_unparent(), qdev bug or qdev misuse?
Date: Tue, 12 May 2020 20:43:32 +0200 [thread overview]
Message-ID: <1bc75209-ff3a-6226-2384-e643e4ab6d77@redhat.com> (raw)
In-Reply-To: <87o8qttaa9.fsf@dusky.pond.sub.org>
On 12/05/20 17:58, Markus Armbruster wrote:
>
> Moving "put on qbus" from qdev_create() (and its wrappers) to
> qdev_init_nofail() means we put on bus by realizing. No use to
> recursive realization then,
... for qdev_init_nofail; it may still be useful to *replace*
qdev_init_nofail with object_property_add_child+qdev_set_parent_bus, and
do recursive realization. The bug wouldn't be hit as long as
qdev_set_parent_bus is only called after object_property_add_child.
Certainly not today though!
Paolo
next prev parent reply other threads:[~2020-05-12 18:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 14:38 Infinite loop in bus_unparent(), qdev bug or qdev misuse? Markus Armbruster
2020-05-04 14:58 ` Paolo Bonzini
2020-05-04 15:25 ` Peter Maydell
2020-05-05 16:03 ` Markus Armbruster
2020-05-05 16:26 ` Paolo Bonzini
2020-05-06 6:39 ` Markus Armbruster
2020-05-12 15:58 ` Markus Armbruster
2020-05-12 18:43 ` Paolo Bonzini [this message]
2020-05-05 8:23 ` no-reply
2020-05-05 8:24 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bc75209-ff3a-6226-2384-e643e4ab6d77@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).