From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: "Leonardo Bras" <leobras@redhat.com>,
eblake@redhat.com, "Daniel P. Berrangé" <berrange@redhat.com>,
farosas@suse.de, kwolf@redhat.com, "Peter Xu" <peterx@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Vladimir Sementsov-Ogievskiy" <vsementsov@yandex-team.ru>,
"Juan Quintela" <quintela@redhat.com>,
qemu-block@nongnu.org, "Coiby Xu" <Coiby.Xu@gmail.com>,
"Fam Zheng" <fam@euphon.net>, "Hanna Reitz" <hreitz@redhat.com>
Subject: Re: [PATCH v2 1/4] nbd: drop unused nbd_receive_negotiate() aio_context argument
Date: Wed, 30 Aug 2023 11:40:13 +0200 [thread overview]
Message-ID: <1bcb98bd-8e77-f071-9b7e-b41edeba78fd@linaro.org> (raw)
In-Reply-To: <20230829160623.277411-2-stefanha@redhat.com>
On 29/8/23 18:06, Stefan Hajnoczi wrote:
> aio_context is always NULL, so drop it.
>
> Suggested-by: Fabiano Rosas <farosas@suse.de>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> include/block/nbd.h | 3 +--
> nbd/client-connection.c | 3 +--
> nbd/client.c | 5 ++---
> qemu-nbd.c | 4 ++--
> 4 files changed, 6 insertions(+), 9 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-08-30 9:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 16:06 [PATCH v2 0/4] io: follow coroutine AioContext in qio_channel_yield() Stefan Hajnoczi
2023-08-29 16:06 ` [PATCH v2 1/4] nbd: drop unused nbd_receive_negotiate() aio_context argument Stefan Hajnoczi
2023-08-29 18:30 ` Eric Blake
2023-08-30 9:40 ` Philippe Mathieu-Daudé [this message]
2023-08-29 16:06 ` [PATCH v2 2/4] nbd: drop unused nbd_start_negotiate() " Stefan Hajnoczi
2023-08-29 18:32 ` Eric Blake
2023-08-30 9:40 ` Philippe Mathieu-Daudé
2023-08-29 16:06 ` [PATCH v2 3/4] io: check there are no qio_channel_yield() coroutines during ->finalize() Stefan Hajnoczi
2023-08-29 16:06 ` [PATCH v2 4/4] io: follow coroutine AioContext in qio_channel_yield() Stefan Hajnoczi
2023-08-29 19:32 ` Eric Blake
2023-08-29 20:29 ` Stefan Hajnoczi
2023-08-30 7:54 ` Daniel P. Berrangé
2023-08-31 13:30 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bcb98bd-8e77-f071-9b7e-b41edeba78fd@linaro.org \
--to=philmd@linaro.org \
--cc=Coiby.Xu@gmail.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=farosas@suse.de \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=leobras@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).