From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33689) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9sSI-0007rA-MX for qemu-devel@nongnu.org; Mon, 06 Jun 2016 07:12:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9sSG-0008Uv-IB for qemu-devel@nongnu.org; Mon, 06 Jun 2016 07:12:25 -0400 References: <1465210604-11661-1-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: <1beaaf48-f6f1-fc58-2f2b-ea5ccc943ef3@redhat.com> Date: Mon, 6 Jun 2016 13:12:15 +0200 MIME-Version: 1.0 In-Reply-To: <1465210604-11661-1-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="H9VOlosXnwwkTKCuvTkgweAqVfNsWPUHw" Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] block: Fix bdrv_all_delete_snapshot() error handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: pbonzini@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --H9VOlosXnwwkTKCuvTkgweAqVfNsWPUHw From: Max Reitz To: Kevin Wolf , qemu-block@nongnu.org Cc: pbonzini@redhat.com, qemu-devel@nongnu.org Message-ID: <1beaaf48-f6f1-fc58-2f2b-ea5ccc943ef3@redhat.com> Subject: Re: [Qemu-block] [PATCH] block: Fix bdrv_all_delete_snapshot() error handling References: <1465210604-11661-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1465210604-11661-1-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 06.06.2016 12:56, Kevin Wolf wrote: > The code to exit the loop after bdrv_snapshot_delete_by_id_or_name() > returned failure was duplicated. The first copy of it was too early so > that the AioContext lock would not be freed. This patch removes it so > that only the second, correct copy remains. >=20 > Signed-off-by: Kevin Wolf > --- > block/snapshot.c | 3 --- > 1 file changed, 3 deletions(-) Reviewed-by: Max Reitz --H9VOlosXnwwkTKCuvTkgweAqVfNsWPUHw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXVVqPAAoJEDuxQgLoOKytOAMH/jEk4ayyZnwClKQUgVLYzNpG sDTzJJgFWsjPsJFgqxXM6NzePzq7TQfg8zSupaHZRZz8OecRX8ZIN88s/+BKkS7L TUdmEqLe9Q2w7KaLaPYlAfuJoog7XkH5HZS+O2FUWpRRDO9UplNtwv9dxFNDcAUz /z1Bhckswb5kwrq9Ph5mN7wvdHAyR9K0g408acI6+WTXaQOQ9STBfa/SosHunXfI cHQZl1X43qyCRFC/yU6HEAw2yMDU/51JUn32X/lZwO/sJ1ECthvbYBBIyJPza+nh opbte2+Gzz1BmwBsOGAAnRJfV2sIdRsc49TmvblnkZqMk0UXbIJARN7i90pQsi8= =vp0y -----END PGP SIGNATURE----- --H9VOlosXnwwkTKCuvTkgweAqVfNsWPUHw--