From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Alexey Kardashevskiy" <aik@ozlabs.ru>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-devel@nongnu.org, "Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] What's IOMMUMemoryRegion's super?
Date: Wed, 3 Jul 2019 07:37:46 +0200 [thread overview]
Message-ID: <1c014d01-edef-d418-75a4-96f0811717e8@redhat.com> (raw)
In-Reply-To: <878stfzozv.fsf@dusky.pond.sub.org>
On 03/07/19 07:05, Markus Armbruster wrote:
> static const TypeInfo iommu_memory_region_info = {
> .parent = TYPE_MEMORY_REGION,
> .name = TYPE_IOMMU_MEMORY_REGION,
> .class_size = sizeof(IOMMUMemoryRegionClass),
> .instance_size = sizeof(IOMMUMemoryRegion),
> .instance_init = iommu_memory_region_initfn,
> .abstract = true,
> };
>
> typedef struct IOMMUMemoryRegionClass {
> /* private */
> ---> struct DeviceClass parent_class;
> [...]
> };
>
> struct IOMMUMemoryRegion {
> MemoryRegion parent_obj;
> [...]
> };
>
> The parent is TYPE_MEMORY_REGION, and the instance struct's first member is
> TYPE_MEMORY_REGION's instance struct as I expect, but the class struct's
> first member is something else entirely.
Cut-and-paste error. MemoryRegion adds no methods so that could be
either ObjectClass or better
typedef struct MemoryRegionClass {
/* private */
ObjectClass parent_class;
} ObjectClass;
Paolo
next prev parent reply other threads:[~2019-07-03 5:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 5:05 [Qemu-devel] What's IOMMUMemoryRegion's super? Markus Armbruster
2019-07-03 5:37 ` Paolo Bonzini [this message]
2019-07-03 6:15 ` David Gibson
2019-07-03 10:37 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c014d01-edef-d418-75a4-96f0811717e8@redhat.com \
--to=pbonzini@redhat.com \
--cc=aik@ozlabs.ru \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).