qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: LIU Zhiwei <zhiwei_liu@c-sky.com>, qemu-devel@nongnu.org
Cc: wenmeng_zhang@c-sky.com, alex.bennee@linaro.org,
	wxy194768@alibaba-inc.com
Subject: Re: [RFC PATCH 5/8] fpu/softfloat: define brain floating-point types
Date: Mon, 13 Jul 2020 12:26:24 -0700	[thread overview]
Message-ID: <1c090feb-0101-ce1a-af8e-2f7e45fd5053@linaro.org> (raw)
In-Reply-To: <20200712234521.3972-6-zhiwei_liu@c-sky.com>

On 7/12/20 4:45 PM, LIU Zhiwei wrote:
> Signed-off-by: LIU Zhiwei <zhiwei_liu@c-sky.com>
> ---
>  include/fpu/softfloat-types.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/include/fpu/softfloat-types.h b/include/fpu/softfloat-types.h
> index 7680193ebc..8f8fdfeecf 100644
> --- a/include/fpu/softfloat-types.h
> +++ b/include/fpu/softfloat-types.h
> @@ -112,6 +112,14 @@ typedef struct {
>  #define make_float128(high_, low_) ((float128) { .high = high_, .low = low_ })
>  #define make_float128_init(high_, low_) { .high = high_, .low = low_ }
>  
> +/*
> + * Software brain floating-point types
> + */
> +typedef uint16_t bfloat16;
> +#define bfloat16_val(x) (x)
> +#define make_bfloat16(x) (x)
> +#define const_bfloat16(x) (x)

I do not like the val/make/const macros.  I've been meaning to get them everywhere.

The word "brain" is better translated as "neural-network" in english.


r~


  reply	other threads:[~2020-07-13 19:27 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-12 23:45 [RFC PATCH 0/8] Implement blfoat16 in softfloat LIU Zhiwei
2020-07-12 23:45 ` [RFC PATCH 1/8] fpu/softfloat: fix up float16 nan recognition LIU Zhiwei
2020-07-13 19:15   ` Richard Henderson
2020-07-13 19:55   ` Alex Bennée
2020-07-12 23:45 ` [RFC PATCH 2/8] fpu/softfloat: use the similiar logic to recognize sNaN and qNaN LIU Zhiwei
2020-07-13 19:17   ` Richard Henderson
2020-07-13 20:15     ` LIU Zhiwei
2020-07-12 23:45 ` [RFC PATCH 3/8] fpu/softfloat: add FloatFmt for bfloat16 LIU Zhiwei
2020-07-13 19:18   ` Richard Henderson
2020-07-13 19:20     ` Richard Henderson
2020-07-12 23:45 ` [RFC PATCH 4/8] fpu/softfloat: add pack and unpack interfaces " LIU Zhiwei
2020-07-13 19:22   ` Richard Henderson
2020-07-12 23:45 ` [RFC PATCH 5/8] fpu/softfloat: define brain floating-point types LIU Zhiwei
2020-07-13 19:26   ` Richard Henderson [this message]
2020-07-13 20:22     ` LIU Zhiwei
2020-07-13 21:48       ` Richard Henderson
2020-07-12 23:45 ` [RFC PATCH 6/8] fpu/softfloat: define operation for bfloat16 LIU Zhiwei
2020-07-13 19:31   ` Richard Henderson
2020-07-12 23:45 ` [RFC PATCH 7/8] fpu/softfloat: define covert " LIU Zhiwei
2020-07-13 19:34   ` Richard Henderson
2020-07-12 23:45 ` [RFC PATCH 8/8] fpu/softfloat: define misc " LIU Zhiwei
2020-07-13 19:37   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c090feb-0101-ce1a-af8e-2f7e45fd5053@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wenmeng_zhang@c-sky.com \
    --cc=wxy194768@alibaba-inc.com \
    --cc=zhiwei_liu@c-sky.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).