qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Cody <jcody@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, grantwwu@gmail.com, qemu-devel@nongnu.org,
	stefanha@redhat.com, sbaugh@catern.com
Subject: [Qemu-devel] [PATCH for-2.6 3/7] block/vpc: use current_size field for XenConverter VHD images
Date: Tue, 22 Mar 2016 23:33:40 -0400	[thread overview]
Message-ID: <1c358f5d72892d6b05a33c29e3b3b037e4a72630.1458702790.git.jcody@redhat.com> (raw)
In-Reply-To: <cover.1458702790.git.jcody@redhat.com>
In-Reply-To: <cover.1458702790.git.jcody@redhat.com>

XenConverter VHD images are another VHD image where current_size is
different from the CHS values in the the format header.  Use
current_size as the default, by looking at the creator_app signature
field.

Signed-off-by: Jeff Cody <jcody@redhat.com>
---
 block/vpc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/block/vpc.c b/block/vpc.c
index 8b8b9a7..6ad8406 100644
--- a/block/vpc.c
+++ b/block/vpc.c
@@ -299,6 +299,7 @@ static int vpc_open(BlockDriverState *bs, QDict *options, int flags,
      *      'win '  :  current_size     Hyper-V
      *      'd2v '  :  current_size     Disk2vhd
      *      'tap\0' :  current_size     XenServer
+     *      'CTXS'  :  current_size     XenConverter
      *
      *  The user can override the table values via drive options, however
      *  even with an override we will still use current_size for images
@@ -307,6 +308,7 @@ static int vpc_open(BlockDriverState *bs, QDict *options, int flags,
     use_chs = (!!strncmp(footer->creator_app, "win ", 4) &&
                !!strncmp(footer->creator_app, "qem2", 4) &&
                !!strncmp(footer->creator_app, "d2v ", 4) &&
+               !!strncmp(footer->creator_app, "CTXS", 4) &&
                !!memcmp(footer->creator_app, "tap", 4)) || s->force_use_chs;
 
     if (!use_chs || bs->total_sectors == VHD_MAX_GEOMETRY || s->force_use_sz) {
-- 
1.9.3

  parent reply	other threads:[~2016-03-23  3:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-23  3:33 [Qemu-devel] [PATCH for-2.6 0/7] block: VHD format fixes Jeff Cody
2016-03-23  3:33 ` [Qemu-devel] [PATCH for-2.6 1/7] block/vpc: fix VPC 'qemu-img create' regression Jeff Cody
2016-03-23 16:56   ` Stefan Hajnoczi
2016-04-13 15:40   ` Jeff Cody
2016-04-13 16:48     ` Kevin Wolf
2016-03-23  3:33 ` [Qemu-devel] [PATCH for-2.6 2/7] vpc: use current_size field for XenServer VHD images Jeff Cody
2016-03-23  3:33 ` Jeff Cody [this message]
2016-03-23  3:33 ` [Qemu-devel] [PATCH for-2.6 4/7] block/vpc: Use the correct max sector count for " Jeff Cody
2016-03-23  3:33 ` [Qemu-devel] [PATCH for-2.6 5/7] block/vpc: make checks on max table size a bit more lax Jeff Cody
2016-03-23  3:33 ` [Qemu-devel] [PATCH for-2.6 6/7] block/vpc: set errp in vpc_open Jeff Cody
2016-03-23  3:33 ` [Qemu-devel] [PATCH for-2.6 7/7] block/vpc: update comments to be compliant w/coding guidelines Jeff Cody
2016-04-13 16:55   ` Kevin Wolf
2016-03-23 18:06 ` [Qemu-devel] [PATCH for-2.6 0/7] block: VHD format fixes Stefan Hajnoczi
2016-04-13 16:57 ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c358f5d72892d6b05a33c29e3b3b037e4a72630.1458702790.git.jcody@redhat.com \
    --to=jcody@redhat.com \
    --cc=grantwwu@gmail.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sbaugh@catern.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).