From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41219) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7jzq-0002CP-Qr for qemu-devel@nongnu.org; Mon, 08 May 2017 10:50:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d7jzp-0000ij-Ug for qemu-devel@nongnu.org; Mon, 08 May 2017 10:50:46 -0400 References: <20170506124314.23354-1-aurelien@aurel32.net> <20170506124314.23354-3-aurelien@aurel32.net> From: John Snow Message-ID: <1c384b57-daba-3a4b-5905-d10c7901653b@redhat.com> Date: Mon, 8 May 2017 10:50:38 -0400 MIME-Version: 1.0 In-Reply-To: <20170506124314.23354-3-aurelien@aurel32.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] ide: export rotational qdev property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, Markus Armbruster , Max Reitz , Paolo Bonzini On 05/06/2017 08:43 AM, Aurelien Jarno wrote: > Export the rotational qdev property in the IDENTIFY request. > > Signed-off-by: Aurelien Jarno > --- > hw/ide/core.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/ide/core.c b/hw/ide/core.c > index 0b48b64d3a..1aa76b0d90 100644 > --- a/hw/ide/core.c > +++ b/hw/ide/core.c > @@ -191,6 +191,9 @@ static void ide_identify(IDEState *s) > if (dev && dev->conf.discard_granularity) { > put_le16(p + 169, 1); /* TRIM support */ > } > + if (dev && !dev->conf.rotational) { > + put_le16(p + 217, 1); /* non-rotating device */ > + } > > ide_identify_size(s); > s->identify_set = 1; > 7.16.7.80 Word 217: Nominal media rotation rate Word 217 is a copy of Nominal Media Rotation Rate (see A.11.5.4). *flips page like it's a choose-your-own-adventure book* OK, so 0x0001 just means "Non-rotational." I guess it probably does not matter that our default is "Rate not reported." Looks like there's no relevant bits for packet identify data either, so: Acked-by: John Snow A question about the series as a whole, though: if by default rotational is set to false, we will newly be setting this bit in IDENTIFY data with identical CLI invocations. Why is that OK?