From: Thomas Huth <thuth@redhat.com>
To: Yi Wang <wang.yi59@zte.com.cn>, qemu-devel@nongnu.org
Cc: Sagar Karandikar <sagark@eecs.berkeley.edu>,
wang.liang82@zte.com.cn, QEMU Trivial <qemu-trivial@nongnu.org>,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
Alistair Francis <Alistair.Francis@wdc.com>,
xue.zhihong@zte.com.cn, Palmer Dabbelt <palmer@dabbelt.com>,
Liao Pingfang <liao.pingfang@zte.com.cn>
Subject: Re: [PATCH 03/12] tcg/riscv: Remove superfluous breaks
Date: Mon, 13 Jul 2020 11:32:26 +0200 [thread overview]
Message-ID: <1c3fd28f-3191-b1d4-ff51-554ed675a5fb@redhat.com> (raw)
In-Reply-To: <1594631044-36284-1-git-send-email-wang.yi59@zte.com.cn>
On 13/07/2020 11.04, Yi Wang wrote:
> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> tcg/riscv/tcg-target.inc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c
> index 2bc0ba7..3c11ab8 100644
> --- a/tcg/riscv/tcg-target.inc.c
> +++ b/tcg/riscv/tcg-target.inc.c
> @@ -502,10 +502,8 @@ static bool patch_reloc(tcg_insn_unit *code_ptr, int type,
> break;
> case R_RISCV_JAL:
> return reloc_jimm20(code_ptr, (tcg_insn_unit *)value);
> - break;
> case R_RISCV_CALL:
> return reloc_call(code_ptr, (tcg_insn_unit *)value);
> - break;
> default:
> tcg_abort();
> }
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2020-07-13 9:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 9:04 [PATCH 03/12] tcg/riscv: Remove superfluous breaks Yi Wang
2020-07-13 9:32 ` Thomas Huth [this message]
2020-07-13 10:37 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c3fd28f-3191-b1d4-ff51-554ed675a5fb@redhat.com \
--to=thuth@redhat.com \
--cc=Alistair.Francis@wdc.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=liao.pingfang@zte.com.cn \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sagark@eecs.berkeley.edu \
--cc=wang.liang82@zte.com.cn \
--cc=wang.yi59@zte.com.cn \
--cc=xue.zhihong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).