From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:40989) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHnQU-0003gJ-46 for qemu-devel@nongnu.org; Sat, 20 Apr 2019 06:40:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hHnQT-000562-6F for qemu-devel@nongnu.org; Sat, 20 Apr 2019 06:40:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57504) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hHnQS-00055X-Un for qemu-devel@nongnu.org; Sat, 20 Apr 2019 06:40:53 -0400 References: <20190418224706.14014-1-programmingkidx@gmail.com> <723372ae-a37a-d7cd-098f-452c7513ce8a@redhat.com> <4B73E5E6-2129-43B8-A35E-0CF7DCAE163B@gmail.com> From: Thomas Huth Message-ID: <1c4c309a-b785-64d2-60ce-4f0501fcc415@redhat.com> Date: Sat, 20 Apr 2019 12:40:48 +0200 MIME-Version: 1.0 In-Reply-To: <4B73E5E6-2129-43B8-A35E-0CF7DCAE163B@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] configure: Change capstone's default state to disabled List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: G 3 Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, Richard Henderson , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= On 19/04/2019 15.44, G 3 wrote: >=20 > On Apr 19, 2019, at 3:10 AM, Thomas Huth wrote: >=20 >> On 19/04/2019 00.47, John Arbuckle wrote: >>> Capstone is not necessary in order to use QEMU. Disable it by default= . >>> This will save the user the pain of having to figure why QEMU isn't >>> building when this library is missing. >>> >>> Signed-off-by: John Arbuckle >>> --- >>> =C2=A0configure | 2 +- >>> =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/configure b/configure >>> index 1c563a7027..77d7967f92 100755 >>> --- a/configure >>> +++ b/configure >>> @@ -433,7 +433,7 @@ opengl_dmabuf=3D"no" >>> =C2=A0cpuid_h=3D"no" >>> =C2=A0avx2_opt=3D"" >>> =C2=A0zlib=3D"yes" >>> -capstone=3D"" >>> +capstone=3D"no" >>> =C2=A0lzo=3D"" >>> =C2=A0snappy=3D"" >>> =C2=A0bzip2=3D"" >> >> AFAIK we ship capstone as a submodule, so how can this be missing? Als= o, >> our philosophy is to keep everything enabled by default if possible, s= o >> that the code paths don't bitrot. Thus I don't think that disabling th= is >> by default is a good idea. ... so if you've got a problem here, there >> must be another solution (e.g. is the system capstone detection not >> working right on your system?). >> >> =C2=A0Thomas >=20 > Thank you for replying. Capstone comes with QEMU? Every time I try to > compile QEMU I see an error relating to Capstone not being on my system= . > Why do you feel that disabling Capstone by default is not a good idea? >=20 > Here is the error message I see when compiling QEMU: >=20 > CHK version_gen.h > make[1]: *** No rule to make target > `/Users/John/qemu-git/capstone/libcapstone.a'.=C2=A0 Stop. > make: *** [subdir-capstone] Error 2 I assume you're using a git checkout here, right? For git checkouts, the Makefile should take care of calling the scripts/git-submodule.sh script which should initialize the submodule in the capstone directory. What's the content of your .git-submodule-status file? What does "configure" say about capstone support on your system? Thomas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97F98C282DD for ; Sat, 20 Apr 2019 10:41:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E62A20850 for ; Sat, 20 Apr 2019 10:41:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E62A20850 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:39793 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHnRC-00041C-II for qemu-devel@archiver.kernel.org; Sat, 20 Apr 2019 06:41:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40989) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHnQU-0003gJ-46 for qemu-devel@nongnu.org; Sat, 20 Apr 2019 06:40:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hHnQT-000562-6F for qemu-devel@nongnu.org; Sat, 20 Apr 2019 06:40:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57504) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hHnQS-00055X-Un for qemu-devel@nongnu.org; Sat, 20 Apr 2019 06:40:53 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EF3BC3082B41; Sat, 20 Apr 2019 10:40:50 +0000 (UTC) Received: from thuth.remote.csb (ovpn-116-21.ams2.redhat.com [10.36.116.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4A3285D9D6; Sat, 20 Apr 2019 10:40:49 +0000 (UTC) To: G 3 References: <20190418224706.14014-1-programmingkidx@gmail.com> <723372ae-a37a-d7cd-098f-452c7513ce8a@redhat.com> <4B73E5E6-2129-43B8-A35E-0CF7DCAE163B@gmail.com> From: Thomas Huth Openpgp: preference=signencrypt Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzRxUaG9tYXMgSHV0 aCA8dGguaHV0aEBnbXguZGU+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIX gAUCUfuWKwIZAQAKCRAu2dd0/nAttbe/EACb9hafyOb2FmhUqeAiBORSsUifFacQ7laVjcgR I4um8CSHvxijYftpkM2EdAtmXIKgbNDpQoXcWLXB9lu9mLgTO4DVT00TRR65ikn3FCWcyT74 ENTOzRKyKLsDCjhXKPblTPIQbYAUCOWElcyAPm0ERd62fA/rKNxgIiNo/l4UODOMoOJm2/Ox ZoTckW68Eqv7k9L7m7j+Hn3hoDTjAmcCBJt+j7pOhzWvCbqoNOIH8C8qvPaNlrba+R/K6jkO 6jZkTbYQpGIofEQJ/TNn38IsNGpI1ALTHWFtoMxp3j2Imz0REO6dRE2fHRN8sVlHgkoeGhmY NbDsDE1jFQOEObFnu0euk//7BXU7tGOHckVAZ8T1smiRPHfQU7UEH2a/grndxJ+PNeM5w7n2 l+FN3cf2KgPotCK2s9MjSdZA7C5e3rFYO8lqiqTJKvc62vqp3e7B0Kjyy5/QtzSOejBij2QL xkKSFNtxIz4MtuxN8e3IDQNxsKry3nF7R4MDvouXlMo6wP9KuyNWb+vFJt9GtbgfDMIFVamp ZfhEWzWRJH4VgksENA4K/BzjEHCcbTUb1TFsiB1VRnBPJ0SqlvifnfKk6HcpkDk6Pg8Q5FOJ gbNHrdgXsm+m/9GF2zUUr+rOlhVbK23TUqKqPfwnD7uxjpakVcJnsVCFqJpZi1F/ga9IN87B TQRR+3lMARAAtp831HniPHb9AuKq3wj83ujZK8lH5RLrfVsB4X1wi47bwo56BqhXpR/zxPTR eOFT0gnbw9UkphVc7uk/alnXMDEmgvnuxv89PwIQX6k3qLABeV7ykJQG/WT5HQ6+2DdGtVw3 2vjYAPiWQeETsgWRRQMDR0/hwp8s8tL/UodwYCScH6Vxx9pdy353L1fK4Bb9G73a+9FPjp9l x+WwKTsltVqSBuSjyZQ3c3EE8qbTidXZxB38JwARH8yN3TX+t65cbBqLl/zRUUUTapHQpUEd yoAsHIml32e4q+3xdLtTdlLi7FgPBItSazcqZPjEcYW73UAuLcmQmfJlQ5PkDiuqcitn+KzH /1pqsTU7QFZjbmSMJyXY0TDErOFuMOjf20b6arcpEqse1V3IKrb+nqqA2azboRm3pEANLAJw iVTwK3qwGRgK5ut6N/Znv20VEHkFUsRAZoOusrIRfR5HFDxlXguAdEz8M/hxXFYYXqOoaCYy 6pJxTjy0Y/tIfmS/g9Bnp8qg9wsrsnk0+XRnDVPak++G3Uq9tJPwpJbyO0vcqEI3vAXkAB7X VXLzvFwi66RrsPUoDkuzj+aCNumtOePDOCpXQGPpKl+l1aYRMN/+lNSk3+1sVuc2C07WnYyE gV/cbEVklPmKrNwu6DeUyD0qI/bVzKMWZAiB1r56hsGeyYcAEQEAAcLBXwQYAQIACQUCUft5 TAIbDAAKCRAu2dd0/nAttYTwEACLAS/THRqXRKb17PQmKwZHerUvZm2klo+lwQ3wNQBHUJAT p2R9ULexyXrJPqjUpy7+voz+FcKiuQBTKyieiIxO46oMxsbXGZ70o3gxjxdYdgimUD6U8PPd JH8tfAL4BR5FZNjspcnscN2jgbF4OrpDeOLyBaj6HPmElNPtECHWCaf1xbIFsZxSDGMA6cUh 0uX3Q8VI7JN1AR2cfiIRY7NrIlWYucJxyKjO3ivWm69nCtsHiJ0wcF8KlVo7F2eLaufo0K8A ynL8SHMF3VEyxsXOP2f1UR9T2Ur30MXcTBpjUxml1TX3RWY5uH89Js/jlIugBwuAmacJ7JYh lTg6sF/GNc4nPb4kk2yktNWTade+TzsllYlJPaorD2Qe8qX0iFUhFC6y9+O6mP4ZvWoYapp9 ezYNuebMgEr93ob1+4sFg3812wNP01WqsGtWCJHnPv/JoonFdMzD/bIkXGEJMk6ks2kxQQZq g6Ik/s/vxOfao/xCn8nHt7GwvVy41795hzK6tbSl+BuyCRp0vfPRP34OnK7+jR2nvQpJu/pU rCELuGwT9hsYkUPjVd4lfylN3mzEc6iAv/wwjsc0DRTSQCpXT3v2ymTAsRKrVaEZLibTXaf+ WslxWek3xNYRiqwwWAJuL652eAlxUgQ5ZS+fXBRTiQpJ+F26I/2lccScRd9G5w== Organization: Red Hat Message-ID: <1c4c309a-b785-64d2-60ce-4f0501fcc415@redhat.com> Date: Sat, 20 Apr 2019 12:40:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <4B73E5E6-2129-43B8-A35E-0CF7DCAE163B@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Sat, 20 Apr 2019 10:40:51 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH] configure: Change capstone's default state to disabled X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190420104048.RgX7G88MGT3U6xgt9MyvUJxDrwj1RAF96HwyIZYb4Yg@z> On 19/04/2019 15.44, G 3 wrote: >=20 > On Apr 19, 2019, at 3:10 AM, Thomas Huth wrote: >=20 >> On 19/04/2019 00.47, John Arbuckle wrote: >>> Capstone is not necessary in order to use QEMU. Disable it by default= . >>> This will save the user the pain of having to figure why QEMU isn't >>> building when this library is missing. >>> >>> Signed-off-by: John Arbuckle >>> --- >>> =C2=A0configure | 2 +- >>> =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/configure b/configure >>> index 1c563a7027..77d7967f92 100755 >>> --- a/configure >>> +++ b/configure >>> @@ -433,7 +433,7 @@ opengl_dmabuf=3D"no" >>> =C2=A0cpuid_h=3D"no" >>> =C2=A0avx2_opt=3D"" >>> =C2=A0zlib=3D"yes" >>> -capstone=3D"" >>> +capstone=3D"no" >>> =C2=A0lzo=3D"" >>> =C2=A0snappy=3D"" >>> =C2=A0bzip2=3D"" >> >> AFAIK we ship capstone as a submodule, so how can this be missing? Als= o, >> our philosophy is to keep everything enabled by default if possible, s= o >> that the code paths don't bitrot. Thus I don't think that disabling th= is >> by default is a good idea. ... so if you've got a problem here, there >> must be another solution (e.g. is the system capstone detection not >> working right on your system?). >> >> =C2=A0Thomas >=20 > Thank you for replying. Capstone comes with QEMU? Every time I try to > compile QEMU I see an error relating to Capstone not being on my system= . > Why do you feel that disabling Capstone by default is not a good idea? >=20 > Here is the error message I see when compiling QEMU: >=20 > CHK version_gen.h > make[1]: *** No rule to make target > `/Users/John/qemu-git/capstone/libcapstone.a'.=C2=A0 Stop. > make: *** [subdir-capstone] Error 2 I assume you're using a git checkout here, right? For git checkouts, the Makefile should take care of calling the scripts/git-submodule.sh script which should initialize the submodule in the capstone directory. What's the content of your .git-submodule-status file? What does "configure" say about capstone support on your system? Thomas