From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40781)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1c6trM-0006Kc-VS
	for qemu-devel@nongnu.org; Wed, 16 Nov 2016 01:38:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1c6trJ-0002N8-Rz
	for qemu-devel@nongnu.org; Wed, 16 Nov 2016 01:38:17 -0500
Received: from smtp2-g21.free.fr ([212.27.42.2]:10311)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <hpoussin@reactos.org>)
	id 1c6trJ-0002Ms-Mi
	for qemu-devel@nongnu.org; Wed, 16 Nov 2016 01:38:13 -0500
References: <1476275861-27613-1-git-send-email-ppandit@redhat.com>
	<33183CC9F5247A488A2544077AF19020B0429759@SZXEMA503-MBS.china.huawei.com>
	<9d8d6a84-1220-2e61-dbdc-b86d5e348bef@redhat.com>
	<292d3a97-4dc9-6678-6a4f-acb5856e91f7@reactos.org>
	<alpine.LFD.2.20.1611161156080.28676@wniryva>
From: =?UTF-8?Q?Herv=c3=a9_Poussineau?= <hpoussin@reactos.org>
Message-ID: <1c634e72-12bd-15f3-23b4-76eda9e13b82@reactos.org>
Date: Wed, 16 Nov 2016 07:37:57 +0100
MIME-Version: 1.0
In-Reply-To: <alpine.LFD.2.20.1611161156080.28676@wniryva>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] dma: rc4030: limit interval timer reload
 value
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: P J P <ppandit@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, "Gonglei (Arei)" <arei.gonglei@huawei.com>, Qemu Developers <qemu-devel@nongnu.org>, Huawei PSIRT <PSIRT@huawei.com>, Aurelien Jarno <aurelien@aurel32.net>, "Michael S. Tsirkin" <mst@redhat.com>

Le 16/11/2016 =E0 07:29, P J P a =E9crit :
> +-- On Wed, 16 Nov 2016, Herv=E9 Poussineau wrote --+
> | I don't have any datasheet for this device either, so I tested with r=
eal
> | programs. Those initialize itr field to either 0 or to 9, so your mas=
k
> | doesn't change anything.
> |
> | Tested-by: Herv=E9 Poussineau <hpoussin@reactos.org>
>
>   Thank you so much. To confirm, do we need to update the mask to maybe
> 0x000F?

No, I think that 0x1ff is fine.
0xf mask means timers between 10ms to 1000ms
0x1ff mask means timers between 2ms to 1000ms, which seem also acceptable=
 to me.

Herv=E9

>
> | > > >      case 0x0228:
> | > > > -        s->itr =3D val;
> | > > > +        s->itr =3D val & 0x01FF;
> | > > >          qemu_irq_lower(s->timer_irq);
>
> Thank you.
> --
> Prasad J Pandit / Red Hat Product Security Team
> 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
>