From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24969C48BF6 for ; Mon, 4 Mar 2024 13:39:48 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rh8Ww-0006jr-Jt; Mon, 04 Mar 2024 08:38:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rh8Wu-0006iu-En for qemu-devel@nongnu.org; Mon, 04 Mar 2024 08:38:56 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rh8Wr-0008B5-UM for qemu-devel@nongnu.org; Mon, 04 Mar 2024 08:38:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709559533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PdOW/+vfp8auSm/Oy6CinDcVC/argrn2ipec37XyauA=; b=OQGWVLXrfHMCqWzcHQqFoJb/DpLyw319Z83j8dUFn07BSlxkLwuN5NZv/DaNBse9Mkaw/I tdBJ/gMW6WD10bW4Ghc6OjBc9M3DNj8+SEoWyzSBQi+P8V6eU7sK7uaPe5oOP2v5aySLeR ERoiETv8uaNUXmlGTRrJUlZQvBQpnko= Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-316-ut5KMpzNPweI9QyzNLKCHw-1; Mon, 04 Mar 2024 08:38:51 -0500 X-MC-Unique: ut5KMpzNPweI9QyzNLKCHw-1 Received: by mail-ot1-f70.google.com with SMTP id 46e09a7af769-6e4e67863eeso793237a34.2 for ; Mon, 04 Mar 2024 05:38:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709559510; x=1710164310; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PdOW/+vfp8auSm/Oy6CinDcVC/argrn2ipec37XyauA=; b=Cuy9BEJcNDGju9rLQCcLNPkIYO5dCm//X3+l9gjyS94oT3OULaEIy0Z9HVNrr98HdM pYD60gUNyu+OS7Zyfa4ul+8xN5hQg5ep5643vv1GrEZq0mFLByUHSDY9p6gnXcqKF39X DMTn//79v5zihXARvdtaGgBoGwBQbj9BYGku7fRhOdHcYwYX0dVXBSg5PXoMXRU1q5O6 lekv0/0cMgeFQ7mxD40xM+EGfNUYCTX2+oxVhDM46IMyrWZjUU8Xht7s5gxm1y2VTFWN JbPUD9da7Rg6JWOVBGyoTlHb72eyi0IMc2lBzecAGmMOYPjNMzHc+vDNaSeiTh9E+uho Zd6A== X-Gm-Message-State: AOJu0YzQsZL/vsO0hFzuysrRGjQY0e7sDch0IdUxGyR9JRzBblgjBrC7 hcBZFwbfbca0xEtr1F8sN9k7tfqtutyBJWMBtnTH+xneaS0p1ecBJYr82o+FUyMaWtF/jGvGBcx ycE9Pb80+CZkdBbD0/8qeTXy8LdJl1ghuSvhMmrqudQAqHGhlc9EmU8br6Bq4 X-Received: by 2002:a05:6870:8190:b0:21e:e85d:4648 with SMTP id k16-20020a056870819000b0021ee85d4648mr10320344oae.44.1709559509894; Mon, 04 Mar 2024 05:38:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IHgLOT2primSUSqs8rynYL/Ge/iluUSFCkurP6rINqPZL+mENIertMvoW+7lpw2vs5O3dkfGQ== X-Received: by 2002:a05:6870:8190:b0:21e:e85d:4648 with SMTP id k16-20020a056870819000b0021ee85d4648mr10320323oae.44.1709559509646; Mon, 04 Mar 2024 05:38:29 -0800 (PST) Received: from ?IPV6:2a01:e0a:280:24f0:9db0:474c:ff43:9f5c? ([2a01:e0a:280:24f0:9db0:474c:ff43:9f5c]) by smtp.gmail.com with ESMTPSA id 19-20020a05620a04d300b00787ad5ca70fsm4352530qks.122.2024.03.04.05.38.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Mar 2024 05:38:29 -0800 (PST) Message-ID: <1c679789-b1a1-4662-acde-d2ef06240c8e@redhat.com> Date: Mon, 4 Mar 2024 14:38:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 08/21] memory: Add Error** argument to .log_global*() handlers Content-Language: en-US, fr To: Peter Xu Cc: qemu-devel@nongnu.org, Fabiano Rosas , Alex Williamson , Avihai Horon , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Stefano Stabellini , Anthony Perard , Paul Durrant , "Michael S . Tsirkin" , Paolo Bonzini , David Hildenbrand References: <20240227180345.548960-1-clg@redhat.com> <20240227180345.548960-9-clg@redhat.com> From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.571, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SORBS_WEB=1.5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hello Peter, I missed this email last week, so I might not have addressed your comments. sorry about that. On 2/29/24 06:29, Peter Xu wrote: > On Tue, Feb 27, 2024 at 07:03:32PM +0100, Cédric Le Goater wrote: >> Modify all log_global*() handlers to take an Error** parameter and >> return a bool. A new MEMORY_LISTENER_CALL_LOG_GLOBAL macro looping on >> the listeners is introduced to handle a possible error, which will >> would interrupt the loop if necessary. >> >> To be noted a change in memory_global_dirty_log_start() behavior as it >> will return as soon as an error is detected. >> >> Cc: Stefano Stabellini >> Cc: Anthony Perard >> Cc: Paul Durrant >> Cc: Michael S. Tsirkin >> Cc: Paolo Bonzini >> Cc: David Hildenbrand >> Signed-off-by: Cédric Le Goater >> --- >> include/exec/memory.h | 15 ++++++-- >> hw/i386/xen/xen-hvm.c | 6 ++-- >> hw/vfio/common.c | 8 +++-- >> hw/virtio/vhost.c | 6 ++-- >> system/memory.c | 83 +++++++++++++++++++++++++++++++++++++------ >> system/physmem.c | 5 +-- >> 6 files changed, 101 insertions(+), 22 deletions(-) >> >> diff --git a/include/exec/memory.h b/include/exec/memory.h >> index 8626a355b310ed7b1a1db7978ba4b394032c2f15..4bc146c5ebdd377cd14a4e462f32cc945db5a0a8 100644 >> --- a/include/exec/memory.h >> +++ b/include/exec/memory.h >> @@ -998,8 +998,11 @@ struct MemoryListener { >> * active at that time. >> * >> * @listener: The #MemoryListener. >> + * @errp: pointer to Error*, to store an error if it happens. >> + * >> + * Return: true on success, else false setting @errp with error. >> */ >> - void (*log_global_start)(MemoryListener *listener); >> + bool (*log_global_start)(MemoryListener *listener, Error **errp); >> >> /** >> * @log_global_stop: >> @@ -1009,8 +1012,11 @@ struct MemoryListener { >> * the address space. >> * >> * @listener: The #MemoryListener. >> + * @errp: pointer to Error*, to store an error if it happens. >> + * >> + * Return: true on success, else false setting @errp with error. >> */ >> - void (*log_global_stop)(MemoryListener *listener); >> + bool (*log_global_stop)(MemoryListener *listener, Error **errp); >> >> /** >> * @log_global_after_sync: >> @@ -1019,8 +1025,11 @@ struct MemoryListener { >> * for any #MemoryRegionSection. >> * >> * @listener: The #MemoryListener. >> + * @errp: pointer to Error*, to store an error if it happens. >> + * >> + * Return: true on success, else false setting @errp with error. >> */ >> - void (*log_global_after_sync)(MemoryListener *listener); >> + bool (*log_global_after_sync)(MemoryListener *listener, Error **errp); >> >> /** >> * @eventfd_add: >> diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c >> index f42621e6742552035122ea58092c91c3458338ff..925a207b494b4eed52d5f360b554f18ac8a9806d 100644 >> --- a/hw/i386/xen/xen-hvm.c >> +++ b/hw/i386/xen/xen-hvm.c >> @@ -446,16 +446,18 @@ static void xen_log_sync(MemoryListener *listener, MemoryRegionSection *section) >> int128_get64(section->size)); >> } >> >> -static void xen_log_global_start(MemoryListener *listener) >> +static bool xen_log_global_start(MemoryListener *listener, Error **errp) >> { >> if (xen_enabled()) { >> xen_in_migration = true; >> } >> + return true; >> } >> >> -static void xen_log_global_stop(MemoryListener *listener) >> +static bool xen_log_global_stop(MemoryListener *listener, Error **errp) >> { >> xen_in_migration = false; >> + return true; >> } >> >> static const MemoryListener xen_memory_listener = { >> diff --git a/hw/vfio/common.c b/hw/vfio/common.c >> index 059bfdc07a85e2eb908df828c1f42104d683e911..8bba95ba6a2010b78cae54c6905857686bbb6309 100644 >> --- a/hw/vfio/common.c >> +++ b/hw/vfio/common.c >> @@ -1075,7 +1075,8 @@ out: >> return ret; >> } >> >> -static void vfio_listener_log_global_start(MemoryListener *listener) >> +static bool vfio_listener_log_global_start(MemoryListener *listener, >> + Error **errp) >> { >> VFIOContainerBase *bcontainer = container_of(listener, VFIOContainerBase, >> listener); >> @@ -1092,9 +1093,11 @@ static void vfio_listener_log_global_start(MemoryListener *listener) >> ret, strerror(-ret)); >> vfio_set_migration_error(ret); >> } >> + return !!ret; >> } >> >> -static void vfio_listener_log_global_stop(MemoryListener *listener) >> +static bool vfio_listener_log_global_stop(MemoryListener *listener, >> + Error **errp) >> { >> VFIOContainerBase *bcontainer = container_of(listener, VFIOContainerBase, >> listener); >> @@ -1111,6 +1114,7 @@ static void vfio_listener_log_global_stop(MemoryListener *listener) >> ret, strerror(-ret)); >> vfio_set_migration_error(ret); >> } >> + return !!ret; >> } > > Shouldn't both of these be "return !ret"? Indeed. It went unnoticed because the return value is not tested when the memory macros MEMORY_LISTENER_CALL_LOG_GLOBAL at run. > > Besides, maybe it'll be easier to go with either: > > 1) if to only add the new parameter, here we can constantly return true > to keep the old behavior, or, > > 2) allow failure within this patch, then error_report() should already do > error_setg() to errp. v3 adds more changes to allow failures. >> >> static int vfio_device_dma_logging_report(VFIODevice *vbasedev, hwaddr iova, >> diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c >> index 2c9ac794680ea9b65eba6cc22e70cf141e90aa73..7a555f941934991a72a2817e5505fe0ce6d6fc64 100644 >> --- a/hw/virtio/vhost.c >> +++ b/hw/virtio/vhost.c >> @@ -1044,7 +1044,7 @@ check_dev_state: >> return r; >> } >> >> -static void vhost_log_global_start(MemoryListener *listener) >> +static bool vhost_log_global_start(MemoryListener *listener, Error **errp) >> { >> int r; >> >> @@ -1052,9 +1052,10 @@ static void vhost_log_global_start(MemoryListener *listener) >> if (r < 0) { >> abort(); >> } >> + return true; >> } >> >> -static void vhost_log_global_stop(MemoryListener *listener) >> +static bool vhost_log_global_stop(MemoryListener *listener, Error **errp) >> { >> int r; >> >> @@ -1062,6 +1063,7 @@ static void vhost_log_global_stop(MemoryListener *listener) >> if (r < 0) { >> abort(); >> } >> + return true; >> } >> >> static void vhost_log_start(MemoryListener *listener, >> diff --git a/system/memory.c b/system/memory.c >> index a229a79988fce2aa3cb77e3a130db4c694e8cd49..af06157ead5b1272548e87f79ab9fb3036055328 100644 >> --- a/system/memory.c >> +++ b/system/memory.c >> @@ -127,6 +127,35 @@ enum ListenerDirection { Forward, Reverse }; >> } \ >> } while (0) >> >> +#define MEMORY_LISTENER_CALL_LOG_GLOBAL(_callback, _direction, _errp, \ >> + _args...) \ >> + do { \ >> + MemoryListener *_listener; \ >> + \ >> + switch (_direction) { \ >> + case Forward: \ >> + QTAILQ_FOREACH(_listener, &memory_listeners, link) { \ >> + if (_listener->_callback) { \ >> + if (!_listener->_callback(_listener, _errp, ##_args)) { \ >> + break; \ >> + } \ >> + } \ >> + } \ >> + break; \ >> + case Reverse: \ >> + QTAILQ_FOREACH_REVERSE(_listener, &memory_listeners, link) { \ >> + if (_listener->_callback) { \ >> + if (!_listener->_callback(_listener, _errp, ##_args)) { \ >> + break; \ >> + } \ >> + } \ >> + } \ >> + break; \ >> + default: \ >> + abort(); \ >> + }; \ >> + } while (0) >> + >> #define MEMORY_LISTENER_CALL(_as, _callback, _direction, _section, _args...) \ >> do { \ >> MemoryListener *_listener; \ >> @@ -2903,7 +2932,13 @@ void memory_global_dirty_log_sync(bool last_stage) >> >> void memory_global_after_dirty_log_sync(void) >> { >> - MEMORY_LISTENER_CALL_GLOBAL(log_global_after_sync, Forward); >> + Error *local_err = NULL; >> + >> + MEMORY_LISTENER_CALL_LOG_GLOBAL(log_global_after_sync, Forward, >> + &local_err); >> + if (local_err) { >> + error_report_err(local_err); >> + } >> } >> >> /* >> @@ -2912,18 +2947,22 @@ void memory_global_after_dirty_log_sync(void) >> */ >> static unsigned int postponed_stop_flags; >> static VMChangeStateEntry *vmstate_change; >> -static void memory_global_dirty_log_stop_postponed_run(void); >> +static bool memory_global_dirty_log_stop_postponed_run(Error **errp); >> >> void memory_global_dirty_log_start(unsigned int flags) >> { >> unsigned int old_flags; >> + Error *local_err = NULL; >> >> assert(flags && !(flags & (~GLOBAL_DIRTY_MASK))); >> >> if (vmstate_change) { >> /* If there is postponed stop(), operate on it first */ >> postponed_stop_flags &= ~flags; >> - memory_global_dirty_log_stop_postponed_run(); >> + if (!memory_global_dirty_log_stop_postponed_run(&local_err)) { >> + error_report_err(local_err); >> + return; >> + } >> } >> >> flags &= ~global_dirty_tracking; >> @@ -2936,15 +2975,22 @@ void memory_global_dirty_log_start(unsigned int flags) >> trace_global_dirty_changed(global_dirty_tracking); >> >> if (!old_flags) { >> - MEMORY_LISTENER_CALL_GLOBAL(log_global_start, Forward); >> + MEMORY_LISTENER_CALL_LOG_GLOBAL(log_global_start, Forward, >> + &local_err); >> + if (local_err) { >> + error_report_err(local_err); >> + return; >> + } >> memory_region_transaction_begin(); >> memory_region_update_pending = true; >> memory_region_transaction_commit(); >> } >> } >> >> -static void memory_global_dirty_log_do_stop(unsigned int flags) >> +static bool memory_global_dirty_log_do_stop(unsigned int flags, Error **errp) >> { >> + ERRP_GUARD(); >> + >> assert(flags && !(flags & (~GLOBAL_DIRTY_MASK))); >> assert((global_dirty_tracking & flags) == flags); >> global_dirty_tracking &= ~flags; >> @@ -2955,39 +3001,49 @@ static void memory_global_dirty_log_do_stop(unsigned int flags) >> memory_region_transaction_begin(); >> memory_region_update_pending = true; >> memory_region_transaction_commit(); >> - MEMORY_LISTENER_CALL_GLOBAL(log_global_stop, Reverse); >> + MEMORY_LISTENER_CALL_LOG_GLOBAL(log_global_stop, Reverse, errp); >> } >> + return !*errp; >> } >> >> /* >> * Execute the postponed dirty log stop operations if there is, then reset >> * everything (including the flags and the vmstate change hook). >> */ >> -static void memory_global_dirty_log_stop_postponed_run(void) >> +static bool memory_global_dirty_log_stop_postponed_run(Error **errp) >> { >> + bool ret = true; >> + >> /* This must be called with the vmstate handler registered */ >> assert(vmstate_change); >> >> /* Note: postponed_stop_flags can be cleared in log start routine */ >> if (postponed_stop_flags) { >> - memory_global_dirty_log_do_stop(postponed_stop_flags); >> + ret = memory_global_dirty_log_do_stop(postponed_stop_flags, errp); >> postponed_stop_flags = 0; >> } >> >> qemu_del_vm_change_state_handler(vmstate_change); >> vmstate_change = NULL; >> + return ret; >> } >> >> static void memory_vm_change_state_handler(void *opaque, bool running, >> RunState state) >> { >> + Error *local_err = NULL; >> + >> if (running) { >> - memory_global_dirty_log_stop_postponed_run(); >> + if (!memory_global_dirty_log_stop_postponed_run(&local_err)) { >> + error_report_err(local_err); >> + } >> } >> } >> >> void memory_global_dirty_log_stop(unsigned int flags) >> { >> + Error *local_err = NULL; >> + >> if (!runstate_is_running()) { >> /* Postpone the dirty log stop, e.g., to when VM starts again */ >> if (vmstate_change) { >> @@ -3001,7 +3057,9 @@ void memory_global_dirty_log_stop(unsigned int flags) >> return; >> } >> >> - memory_global_dirty_log_do_stop(flags); >> + if (!memory_global_dirty_log_do_stop(flags, &local_err)) { >> + error_report_err(local_err); >> + } >> } >> >> static void listener_add_address_space(MemoryListener *listener, >> @@ -3009,13 +3067,16 @@ static void listener_add_address_space(MemoryListener *listener, >> { >> FlatView *view; >> FlatRange *fr; >> + Error *local_err = NULL; >> >> if (listener->begin) { >> listener->begin(listener); >> } >> if (global_dirty_tracking) { >> if (listener->log_global_start) { >> - listener->log_global_start(listener); >> + if (!listener->log_global_start(listener, &local_err)) { >> + error_report_err(local_err); >> + } >> } >> } > > The stop process is indeed more involved due to the postponed mechanism. > > Is it really a goal that we should also allow global stop() to be able to > fail? Or maybe we only care about global start() on the "VFIO doesn't have > enough dirty tracking unit for the current device" issue? So you would rather keep the stop handler prototype as it is ? I made the log global stop and start handlers similar for symmetry but I am fine not changing stop. That said, the stop handler changes are much easier to address. > It makes more sense to me to allow a start() to fail rather than stop(), The approach I took for the stop sequence is to keep the same behavior and to only report the error, but no actions are taken. I should improve the commit log if we keep the stop changes. > because if start()s failed we can still fallback to stop() on whatever got > start()ed already, and fail the operation that triggered the start(). Yes. The goal is to resume the guest execution "gracefully", with some error. > If stop() can also fail I don't know what we can do; consider if the > fallback stop()s failed above. It sounds just more challenging to allow > stop() to fail v.s. start() only from that regard to behave correctly. Yes. this would be just for error reporting. > Same question to after_sync(); that seems only to be used by tcg. If VFIO > has no plan to leverage that Error** maybe we can keep them as-is? AFAICS log_global_after_sync() handlers are called from ram_init_bitmaps() ram_init_bitmaps migration_bitmap_sync_precopy migration_bitmap_sync memory_global_dirty_log_sync memory_region_sync_dirty_bitmap calls .log_sync() handlers memory_global_after_dirty_log_sync calls .log_global_after_sync() handlers The .log_global_after_sync() change is not necessary for VFIO. It is proposed mostly for symmetry of the .log_global* handlers and because migration_bitmap_sync_precopy() and migration_bitmap_sync() could fail. I agree we can keep this change for later. It would be in v4 now. Sorry about that. Also, it would be interesting to have the .log_sync() handler report an error since it is used by VFIO in the 'save_setup' migration step. I think we should address .log_global_after_sync() and .log_sync() all together in a new series. Thanks, C. > >> >> diff --git a/system/physmem.c b/system/physmem.c >> index e3ebc19eefd8050a1dee16e3d1449f0c144f751f..9adbf9aea847cd80bdac6dca466fb476844ac048 100644 >> --- a/system/physmem.c >> +++ b/system/physmem.c >> @@ -148,7 +148,7 @@ typedef struct subpage_t { >> >> static void io_mem_init(void); >> static void memory_map_init(void); >> -static void tcg_log_global_after_sync(MemoryListener *listener); >> +static bool tcg_log_global_after_sync(MemoryListener *listener, Error **errp); >> static void tcg_commit(MemoryListener *listener); >> >> /** >> @@ -2475,7 +2475,7 @@ static void do_nothing(CPUState *cpu, run_on_cpu_data d) >> { >> } >> >> -static void tcg_log_global_after_sync(MemoryListener *listener) >> +static bool tcg_log_global_after_sync(MemoryListener *listener, Error **errp) >> { >> CPUAddressSpace *cpuas; >> >> @@ -2507,6 +2507,7 @@ static void tcg_log_global_after_sync(MemoryListener *listener) >> cpuas = container_of(listener, CPUAddressSpace, tcg_as_listener); >> run_on_cpu(cpuas->cpu, do_nothing, RUN_ON_CPU_NULL); >> } >> + return true; >> } >> >> static void tcg_commit_cpu(CPUState *cpu, run_on_cpu_data data) >> -- >> 2.43.2 >> >