From: Richard Henderson <richard.henderson@linaro.org>
To: Song Gao <gaosong@loongson.cn>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, yangxiaojuan@loongson.cn
Subject: Re: [PATCH] hw/loongarch: remove acpi-build.c unused variable 'aml_len'
Date: Fri, 5 Aug 2022 09:57:33 -0700 [thread overview]
Message-ID: <1c7b471e-6e50-069f-4107-b638e1211adb@linaro.org> (raw)
In-Reply-To: <20220721040046.3985609-1-gaosong@loongson.cn>
On 7/20/22 21:00, Song Gao wrote:
> @@ -413,7 +413,6 @@ static void acpi_build(AcpiBuildTables *tables, MachineState *machine)
> AcpiFadtData fadt_data;
> unsigned facs, rsdt, fadt, dsdt;
> uint8_t *u;
> - size_t aml_len = 0;
...
> @@ -451,7 +444,6 @@ static void acpi_build(AcpiBuildTables *tables, MachineState *machine)
> fadt_data.xdsdt_tbl_offset = &dsdt;
> build_fadt(tables_blob, tables->linker, &fadt_data,
> lams->oem_id, lams->oem_table_id);
> - aml_len += tables_blob->len - fadt;
This in turn removes the last use of fadt.
r~
prev parent reply other threads:[~2022-08-05 16:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 4:00 [PATCH] hw/loongarch: remove acpi-build.c unused variable 'aml_len' Song Gao
2022-07-24 3:27 ` Richard Henderson
2022-08-05 6:52 ` gaosong
2022-08-05 15:22 ` Richard Henderson
2022-08-05 16:57 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c7b471e-6e50-069f-4107-b638e1211adb@linaro.org \
--to=richard.henderson@linaro.org \
--cc=gaosong@loongson.cn \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=yangxiaojuan@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).