From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH 15/31] tcg: Replace TCG_TARGET_CALL_ALIGN_ARGS with TCG_TARGET_CALL_ARG_I64
Date: Thu, 20 Oct 2022 17:12:47 +0200 [thread overview]
Message-ID: <1c9f842b-5f19-b85c-5ec4-30c8baba52a3@linaro.org> (raw)
In-Reply-To: <20221020115242.2301066-16-richard.henderson@linaro.org>
On 20/10/22 13:52, Richard Henderson wrote:
> For 32-bit hosts when TCG_TARGET_CALL_ALIGN_ARGS was set, use
> TCG_CALL_ARG_EVEN. For 64-bit hosts, TCG_TARGET_CALL_ALIGN_ARGS
> was silently ignored, so always use TCG_CALL_ARG_NORMAL.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tcg/aarch64/tcg-target.h | 2 +-
> tcg/arm/tcg-target.h | 2 +-
> tcg/i386/tcg-target.h | 1 +
> tcg/loongarch64/tcg-target.h | 2 +-
> tcg/mips/tcg-target.h | 3 ++-
> tcg/riscv/tcg-target.h | 2 +-
> tcg/s390x/tcg-target.h | 1 +
> tcg/sparc64/tcg-target.h | 1 +
> tcg/tci/tcg-target.h | 5 +++++
> tcg/tcg.c | 6 ++++--
> tcg/ppc/tcg-target.c.inc | 21 ++++++++-------------
> 11 files changed, 26 insertions(+), 20 deletions(-)
> diff --git a/tcg/riscv/tcg-target.h b/tcg/riscv/tcg-target.h
> index 11c9b3e4f4..0b2171ebf0 100644
> --- a/tcg/riscv/tcg-target.h
> +++ b/tcg/riscv/tcg-target.h
> @@ -81,8 +81,8 @@ typedef enum {
> /* used for function call generation */
> #define TCG_REG_CALL_STACK TCG_REG_SP
> #define TCG_TARGET_STACK_ALIGN 16
> -#define TCG_TARGET_CALL_ALIGN_ARGS 1
> #define TCG_TARGET_CALL_STACK_OFFSET 0
> +#define TCG_TARGET_CALL_ARG_I64 TCG_CALL_ARG_NORMAL
Don't we want to use the even arg on RV32 hosts?
#if TCG_TARGET_REG_BITS == 32
# define TCG_TARGET_CALL_ARG_I64 TCG_CALL_ARG_EVEN
#else
# define TCG_TARGET_CALL_ARG_I64 TCG_CALL_ARG_NORMAL
#endif
next prev parent reply other threads:[~2022-10-20 16:30 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 11:52 [PATCH 00/31] tcg: Support for Int128 with helpers Richard Henderson
2022-10-20 11:52 ` [PATCH 01/31] tcg: Tidy tcg_reg_alloc_op Richard Henderson
2022-10-20 11:52 ` [PATCH 02/31] tcg: Introduce paired register allocation Richard Henderson
2022-10-20 11:52 ` [PATCH 03/31] tcg/s390x: Use register pair allocation for div and mulu2 Richard Henderson
2022-10-20 11:52 ` [PATCH 04/31] tcg/arm: Use register pair allocation for qemu_{ld, st}_i64 Richard Henderson
2022-10-20 11:52 ` [PATCH 05/31] meson: Move CONFIG_TCG_INTERPRETER to config_host Richard Henderson
2022-10-20 11:52 ` [PATCH 06/31] tcg: Remove TCG_TARGET_STACK_GROWSUP Richard Henderson
2022-10-20 15:25 ` Philippe Mathieu-Daudé
2022-10-20 11:52 ` [PATCH 07/31] accel/tcg: Set cflags_next_tb in cpu_common_initfn Richard Henderson
2022-10-20 11:52 ` [PATCH 08/31] target/sparc: Avoid TCGV_{LOW,HIGH} Richard Henderson
2022-10-20 11:52 ` [PATCH 09/31] tcg: Move TCG_{LOW,HIGH} to tcg-internal.h Richard Henderson
2022-10-20 14:52 ` Philippe Mathieu-Daudé
2022-10-20 11:52 ` [PATCH 10/31] tcg: Add temp_subindex to TCGTemp Richard Henderson
2022-10-20 14:57 ` Philippe Mathieu-Daudé
2022-10-20 11:52 ` [PATCH 11/31] tcg: Allocate TCGTemp pairs in host memory order Richard Henderson
2022-10-20 15:01 ` Philippe Mathieu-Daudé
2022-10-20 21:33 ` Richard Henderson
2022-10-20 11:52 ` [PATCH 12/31] tcg: Move TCG_TYPE_COUNT outside enum Richard Henderson
2022-10-20 15:03 ` Philippe Mathieu-Daudé
2022-10-20 11:52 ` [PATCH 13/31] tcg: Introduce tcg_type_size Richard Henderson
2022-10-20 11:52 ` [PATCH 14/31] tcg: Introduce TCGCallReturnKind and TCGCallArgumentKind Richard Henderson
2022-10-20 11:52 ` [PATCH 15/31] tcg: Replace TCG_TARGET_CALL_ALIGN_ARGS with TCG_TARGET_CALL_ARG_I64 Richard Henderson
2022-10-20 15:12 ` Philippe Mathieu-Daudé [this message]
2022-10-20 21:39 ` Richard Henderson
2022-10-20 11:52 ` [PATCH 16/31] tcg: Replace TCG_TARGET_EXTEND_ARGS with TCG_TARGET_CALL_ARG_I32 Richard Henderson
2022-10-20 11:52 ` [PATCH 17/31] tcg: Use TCG_CALL_ARG_EVEN for TCI special case Richard Henderson
2022-10-20 11:52 ` [PATCH 18/31] tcg: Reorg function calls Richard Henderson
2022-10-20 11:52 ` [PATCH 19/31] tcg: Move ffi_cif pointer into TCGHelperInfo Richard Henderson
2022-10-20 11:52 ` [PATCH 20/31] tcg: Add TCGHelperInfo argument to tcg_out_call Richard Henderson
2022-10-20 15:41 ` Philippe Mathieu-Daudé
2022-10-20 11:52 ` [PATCH 21/31] tcg: Define TCG_TYPE_I128 and related helper macros Richard Henderson
2022-10-20 11:52 ` [PATCH 22/31] tcg: Add TCG_CALL_{RET,ARG}_NORMAL_4 Richard Henderson
2022-10-20 11:52 ` [PATCH 23/31] tcg: Allocate objects contiguously in temp_allocate_frame Richard Henderson
2022-10-20 11:52 ` [PATCH 24/31] tcg: Introduce tcg_out_addi_ptr Richard Henderson
2022-10-20 11:52 ` [PATCH 25/31] tcg: Add TCG_CALL_{RET,ARG}_BY_REF Richard Henderson
2022-10-20 11:52 ` [PATCH 26/31] tcg: Introduce tcg_target_call_oarg_reg Richard Henderson
2022-10-20 11:52 ` [PATCH 27/31] tcg: Add TCG_CALL_RET_BY_VEC Richard Henderson
2022-10-20 11:52 ` [PATCH 28/31] include/qemu/int128: Use Int128 structure for TCI Richard Henderson
2022-10-20 11:52 ` [PATCH 29/31] tcg: Add TCG_TARGET_CALL_{RET,ARG}_I128 Richard Henderson
2022-10-20 11:52 ` [PATCH 30/31] tcg: Add temp allocation for TCGv_i128 Richard Henderson
2022-10-20 11:52 ` [PATCH 31/31] tcg: Add tcg_gen_extr_i128_i64, tcg_gen_concat_i64_i128 Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c9f842b-5f19-b85c-5ec4-30c8baba52a3@linaro.org \
--to=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).