From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C5BBC4332F for ; Thu, 20 Oct 2022 16:30:20 +0000 (UTC) Received: from localhost ([::1]:51032 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olYR0-0004os-VK for qemu-devel@archiver.kernel.org; Thu, 20 Oct 2022 12:30:19 -0400 Received: from [::1] (helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olYMM-0003zj-OC for qemu-devel@archiver.kernel.org; Thu, 20 Oct 2022 12:25:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49392) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olXE6-0000Db-Rg for qemu-devel@nongnu.org; Thu, 20 Oct 2022 11:12:54 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:44782) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1olXE4-0003q0-14 for qemu-devel@nongnu.org; Thu, 20 Oct 2022 11:12:54 -0400 Received: by mail-wr1-x434.google.com with SMTP id v1so5779951wrt.11 for ; Thu, 20 Oct 2022 08:12:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XkDy/b+ijAiCPbIFahJlLSyHa5y3pvjYqtgF9qFWtLk=; b=tRIemqNMFV7zxPN/vndKnAz80MSxyhuiG1OFEpLjmPFPS15CthLXXDa7dxHZJRDEST IC3jOktrriRCnPjeiLXFiAqeE4nZLC45t8ABMASrt8ArYQlbz/L0CqbpMw4aSKOS52AZ 7RNPXEd0GNZQar+TUh4Dm+tSRsVyexP/CrdgsLiqXbnvJulUboAciLhZEYj8FRnSWEqc SYv154vbOw0nkig9KqbMtD8JapOwY9PpxbowPHEGr24AJzi1HRgbyEMJ4EonJyyvB2bI ZS+wkV6bqgzMtZbmnzSvw4grckLoYMmbuDNe8QAxOPDfPtHzmJ7BldMqvMvpGKd8pY8B tDtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XkDy/b+ijAiCPbIFahJlLSyHa5y3pvjYqtgF9qFWtLk=; b=SWU3N5l3RXb4/FEjllnQs0y7RDQpK2YTckCVrYrRpWbwHoFLzJ6qpAA9OuPS+85Hi1 +VwVRbklGTaiA4icB5G8gndQuKOlV6uFfXajB91f1WwYwZcIr6Si2g0sJhuZb220SJKI BniTde2CqJ+YBJuAkab6S8i8OJDDH2htWNGedgvPIL55r8YTe8MeKc9bX5Ggpc6MDUEh UkAO/d+pqMeNybKSOmFk3OP0VYDkvTI64JKRY50NB0Dp9FsHyfIjuKO0U+wpoz1Z2tLD k5aw7oFR7EgODicRIMG5i885rq3QD/bSxQVnYcNaCjf0uk/OJ7Mtb8E9ZvBzm2yB5TpI oQbg== X-Gm-Message-State: ACrzQf3yRIsjhJ/Ch51trdlw6NWhblvW1ub7Zd/r4OnZf+QoXRxMeS5i iU6H+uM5HXX9vZl4r6t2tyga0A== X-Google-Smtp-Source: AMsMyM7rc2evrFMF/nA+iNhTw+K1+CX/khCLhRlcWCu6jYqsJetJD+vbeDK6t0N4FZwVNJ+KanOuiA== X-Received: by 2002:a5d:64af:0:b0:230:1aca:634 with SMTP id m15-20020a5d64af000000b002301aca0634mr9423467wrp.74.1666278770219; Thu, 20 Oct 2022 08:12:50 -0700 (PDT) Received: from [10.50.0.10] (ec2-54-194-108-71.eu-west-1.compute.amazonaws.com. [54.194.108.71]) by smtp.gmail.com with ESMTPSA id p24-20020a05600c1d9800b003c6f426467fsm26074wms.40.2022.10.20.08.12.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Oct 2022 08:12:48 -0700 (PDT) Message-ID: <1c9f842b-5f19-b85c-5ec4-30c8baba52a3@linaro.org> Date: Thu, 20 Oct 2022 17:12:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH 15/31] tcg: Replace TCG_TARGET_CALL_ALIGN_ARGS with TCG_TARGET_CALL_ARG_I64 Content-Language: en-US To: Richard Henderson , qemu-devel@nongnu.org References: <20221020115242.2301066-1-richard.henderson@linaro.org> <20221020115242.2301066-16-richard.henderson@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20221020115242.2301066-16-richard.henderson@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=philmd@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 20/10/22 13:52, Richard Henderson wrote: > For 32-bit hosts when TCG_TARGET_CALL_ALIGN_ARGS was set, use > TCG_CALL_ARG_EVEN. For 64-bit hosts, TCG_TARGET_CALL_ALIGN_ARGS > was silently ignored, so always use TCG_CALL_ARG_NORMAL. > > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.h | 2 +- > tcg/arm/tcg-target.h | 2 +- > tcg/i386/tcg-target.h | 1 + > tcg/loongarch64/tcg-target.h | 2 +- > tcg/mips/tcg-target.h | 3 ++- > tcg/riscv/tcg-target.h | 2 +- > tcg/s390x/tcg-target.h | 1 + > tcg/sparc64/tcg-target.h | 1 + > tcg/tci/tcg-target.h | 5 +++++ > tcg/tcg.c | 6 ++++-- > tcg/ppc/tcg-target.c.inc | 21 ++++++++------------- > 11 files changed, 26 insertions(+), 20 deletions(-) > diff --git a/tcg/riscv/tcg-target.h b/tcg/riscv/tcg-target.h > index 11c9b3e4f4..0b2171ebf0 100644 > --- a/tcg/riscv/tcg-target.h > +++ b/tcg/riscv/tcg-target.h > @@ -81,8 +81,8 @@ typedef enum { > /* used for function call generation */ > #define TCG_REG_CALL_STACK TCG_REG_SP > #define TCG_TARGET_STACK_ALIGN 16 > -#define TCG_TARGET_CALL_ALIGN_ARGS 1 > #define TCG_TARGET_CALL_STACK_OFFSET 0 > +#define TCG_TARGET_CALL_ARG_I64 TCG_CALL_ARG_NORMAL Don't we want to use the even arg on RV32 hosts? #if TCG_TARGET_REG_BITS == 32 # define TCG_TARGET_CALL_ARG_I64 TCG_CALL_ARG_EVEN #else # define TCG_TARGET_CALL_ARG_I64 TCG_CALL_ARG_NORMAL #endif