From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:59347) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1LFp-0004Tl-1M for qemu-devel@nongnu.org; Tue, 05 Mar 2019 20:21:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1LFo-0004Dv-E3 for qemu-devel@nongnu.org; Tue, 05 Mar 2019 20:21:53 -0500 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]:42863) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h1LFo-0004Dl-6a for qemu-devel@nongnu.org; Tue, 05 Mar 2019 20:21:52 -0500 Received: by mail-pf1-x436.google.com with SMTP id n74so7106309pfi.9 for ; Tue, 05 Mar 2019 17:21:52 -0800 (PST) References: <20190305172139.32662-1-peter.maydell@linaro.org> <20190305172139.32662-11-peter.maydell@linaro.org> From: Richard Henderson Message-ID: <1ccaeb82-3182-21e1-a81b-5f876e6d0929@linaro.org> Date: Tue, 5 Mar 2019 14:33:50 -0800 MIME-Version: 1.0 In-Reply-To: <20190305172139.32662-11-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 10/12] Makefile: Abstract out "identify the pkgversion" code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: =?UTF-8?Q?Alex_Benn=c3=a9e?= , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Aleksandar Markovic On 3/5/19 9:21 AM, Peter Maydell wrote: > + if test -d .git; then \ As mentioned somewhere else this week, test -e, since .git may be a file. Otherwise, Reviewed-by: Richard Henderson r~