From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Michael Roth <mdroth@linux.vnet.ibm.com>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] tests/test-qga: Reenable guest-agent qtest
Date: Tue, 29 Jan 2019 09:58:58 +0100 [thread overview]
Message-ID: <1ccd70de-74b4-e306-5bfd-7410a8e33c59@redhat.com> (raw)
In-Reply-To: <20190129083807.11681-1-philmd@redhat.com>
On 2019-01-29 09:38, Philippe Mathieu-Daudé wrote:
> Due to a misuse of rules.mak logical functions, commit f386df17448
> disabled the guest-agent test.
> Enable it back.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> From rules.mak:
>
> # Logical functions (for operating on y/n values like CONFIG_FOO vars)
> # Usage: $(call land,$(CONFIG_FOO),$(CONFIG_BAR))
> ---
> tests/Makefile.include | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 19b4c0a696..172128b058 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -110,7 +110,7 @@ check-unit-y += tests/test-crypto-secret$(EXESUF)
> check-unit-$(CONFIG_GNUTLS) += tests/test-crypto-tlscredsx509$(EXESUF)
> check-unit-$(CONFIG_GNUTLS) += tests/test-crypto-tlssession$(EXESUF)
> ifneq (,$(findstring qemu-ga,$(TOOLS)))
> -check-unit-$(land,$(CONFIG_LINUX),$(CONFIG_VIRTIO_SERIAL)) += tests/test-qga$(EXESUF)
> +check-unit-$(call land,$(CONFIG_LINUX),$(CONFIG_VIRTIO_SERIAL)) += tests/test-qga$(EXESUF)
> endif
> check-unit-y += tests/test-timed-average$(EXESUF)
> check-unit-y += tests/test-util-sockets$(EXESUF)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2019-01-29 8:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 8:38 [Qemu-devel] [PATCH] tests/test-qga: Reenable guest-agent qtest Philippe Mathieu-Daudé
2019-01-29 8:58 ` Thomas Huth [this message]
2019-01-29 9:11 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ccd70de-74b4-e306-5bfd-7410a8e33c59@redhat.com \
--to=thuth@redhat.com \
--cc=lvivier@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).