From: Richard Henderson <richard.henderson@linaro.org>
To: "Thomas Huth" <thuth@redhat.com>,
qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Wainer dos Santos Moschetta <wainersm@redhat.com>,
Stefan Weil <sw@weilnetz.de>
Subject: Re: [PATCH 08/11] stubs/notify-event: Mark qemu_notify_event() stub as "weak"
Date: Tue, 4 Aug 2020 10:50:36 -0700 [thread overview]
Message-ID: <1cd4b50f-7195-ac05-cd37-c7681747fbf3@linaro.org> (raw)
In-Reply-To: <20200804170055.2851-9-thuth@redhat.com>
On 8/4/20 10:00 AM, Thomas Huth wrote:
> Otherwise there is a linker error with MinGW while compiling the tests:
>
> LINK tests/test-timed-average.exe
> libqemuutil.a(main-loop.o): In function `qemu_notify_event':
> /builds/huth/qemu/util/main-loop.c:139: multiple definition of
> `qemu_notify_event'
> tests/test-timed-average.o:/builds/huth/qemu/tests/../stubs/notify-event.c:5:
> first defined here
> collect2: error: ld returned 1 exit status
> /builds/huth/qemu/rules.mak:124: recipe for target
> 'tests/test-timed-average.exe' failed
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> stubs/notify-event.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
That doesn't make sense. Since the symbol is satisfied from main-loop.c, it
should not be pulled in from libqemuutil.a.
What's really happening here?
r~
next prev parent reply other threads:[~2020-08-04 17:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 17:00 [PATCH 00/11] Run cross-compilation build tests in the gitlab-CI Thomas Huth
2020-08-04 17:00 ` [PATCH 01/11] virtio-mem: Correct format specifier mismatch for RISC-V Thomas Huth
2020-08-04 17:00 ` [PATCH 02/11] target/riscv/vector_helper: Fix build on 32-bit big endian targets Thomas Huth
2020-08-04 17:34 ` Richard Henderson
2020-08-04 17:46 ` Philippe Mathieu-Daudé
2020-08-05 8:45 ` Thomas Huth
2020-08-04 17:00 ` [PATCH 03/11] tests/Makefile: test-image-locking needs CONFIG_POSIX Thomas Huth
2020-08-04 17:00 ` [PATCH 04/11] tests/Makefile: test-replication " Thomas Huth
2020-08-04 17:00 ` [PATCH 05/11] tests/Makefile: Only build usable targets during 'make check-build' Thomas Huth
2020-08-04 17:00 ` [PATCH 06/11] tests/Makefile: Add $(EXESUF) to fp-test target Thomas Huth
2020-08-04 17:45 ` Richard Henderson
2020-08-04 17:51 ` Philippe Mathieu-Daudé
2020-08-12 9:47 ` Paolo Bonzini
2020-08-04 17:00 ` [PATCH 07/11] Get rid of the libqemustub.a remainders Thomas Huth
2020-08-04 17:46 ` Richard Henderson
2020-08-04 17:00 ` [PATCH 08/11] stubs/notify-event: Mark qemu_notify_event() stub as "weak" Thomas Huth
2020-08-04 17:50 ` Richard Henderson [this message]
2020-08-04 18:20 ` Thomas Huth
2020-08-12 9:47 ` Paolo Bonzini
2020-08-04 17:00 ` [PATCH 09/11] gitlab-ci: Add cross-compiling build tests Thomas Huth
2020-08-04 17:00 ` [PATCH 10/11] configure: Allow automatic WHPX detection Thomas Huth
2020-08-04 17:47 ` Philippe Mathieu-Daudé
2020-08-04 18:25 ` Stefan Weil
2020-08-04 17:00 ` [PATCH 11/11] dockerfiles/debian-win64-cross: Download WHPX MinGW headers Thomas Huth
2020-08-04 18:07 ` Philippe Mathieu-Daudé
2020-08-04 18:32 ` Stefan Weil
2020-08-05 6:28 ` Thomas Huth
2020-08-05 9:11 ` Daniel P. Berrangé
2020-08-05 12:54 ` 罗勇刚(Yonggang Luo)
2020-08-04 17:05 ` [PATCH 00/11] Run cross-compilation build tests in the gitlab-CI Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cd4b50f-7195-ac05-cd37-c7681747fbf3@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).