* [PATCH] hw/intc/i8259: Remove unused DEBUG_PIC define
@ 2025-04-23 10:11 BALATON Zoltan
2025-04-23 10:24 ` Mark Cave-Ayland
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: BALATON Zoltan @ 2025-04-23 10:11 UTC (permalink / raw)
To: qemu-devel, qemu-trivial; +Cc: Michael S. Tsirkin, Paolo Bonzini
The debug printfs were converted to traces so this define is now unused.
Fixes: 0880a87300 (i8259: convert DPRINTFs into trace)
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
hw/intc/i8259.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c
index d88b20f40b..6a204f7d21 100644
--- a/hw/intc/i8259.c
+++ b/hw/intc/i8259.c
@@ -32,10 +32,7 @@
#include "trace.h"
#include "qom/object.h"
-/* debug PIC */
-//#define DEBUG_PIC
-
-//#define DEBUG_IRQ_LATENCY
+/*#define DEBUG_IRQ_LATENCY*/
#define TYPE_I8259 "isa-i8259"
typedef struct PICClass PICClass;
--
2.41.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] hw/intc/i8259: Remove unused DEBUG_PIC define
2025-04-23 10:11 [PATCH] hw/intc/i8259: Remove unused DEBUG_PIC define BALATON Zoltan
@ 2025-04-23 10:24 ` Mark Cave-Ayland
2025-04-23 11:17 ` Philippe Mathieu-Daudé
2025-04-25 10:43 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Mark Cave-Ayland @ 2025-04-23 10:24 UTC (permalink / raw)
To: BALATON Zoltan, qemu-devel, qemu-trivial; +Cc: Michael S.Tsirkin, Paolo Bonzini
On 23/04/2025 11:11, BALATON Zoltan wrote:
> The debug printfs were converted to traces so this define is now unused.
>
> Fixes: 0880a87300 (i8259: convert DPRINTFs into trace)
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/intc/i8259.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c
> index d88b20f40b..6a204f7d21 100644
> --- a/hw/intc/i8259.c
> +++ b/hw/intc/i8259.c
> @@ -32,10 +32,7 @@
> #include "trace.h"
> #include "qom/object.h"
>
> -/* debug PIC */
> -//#define DEBUG_PIC
> -
> -//#define DEBUG_IRQ_LATENCY
> +/*#define DEBUG_IRQ_LATENCY*/
>
> #define TYPE_I8259 "isa-i8259"
> typedef struct PICClass PICClass;
Reviewed-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
ATB,
Mark.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/intc/i8259: Remove unused DEBUG_PIC define
2025-04-23 10:11 [PATCH] hw/intc/i8259: Remove unused DEBUG_PIC define BALATON Zoltan
2025-04-23 10:24 ` Mark Cave-Ayland
@ 2025-04-23 11:17 ` Philippe Mathieu-Daudé
2025-04-25 10:43 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-04-23 11:17 UTC (permalink / raw)
To: BALATON Zoltan, qemu-devel, qemu-trivial
Cc: Michael S. Tsirkin, Paolo Bonzini
On 23/4/25 12:11, BALATON Zoltan wrote:
> The debug printfs were converted to traces so this define is now unused.
>
> Fixes: 0880a87300 (i8259: convert DPRINTFs into trace)
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/intc/i8259.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
and queued, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/intc/i8259: Remove unused DEBUG_PIC define
2025-04-23 10:11 [PATCH] hw/intc/i8259: Remove unused DEBUG_PIC define BALATON Zoltan
2025-04-23 10:24 ` Mark Cave-Ayland
2025-04-23 11:17 ` Philippe Mathieu-Daudé
@ 2025-04-25 10:43 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-04-25 10:43 UTC (permalink / raw)
To: BALATON Zoltan, qemu-devel, qemu-trivial
Cc: Michael S. Tsirkin, Paolo Bonzini
On 23/4/25 12:11, BALATON Zoltan wrote:
> The debug printfs were converted to traces so this define is now unused.
>
> Fixes: 0880a87300 (i8259: convert DPRINTFs into trace)
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/intc/i8259.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
Patch queued, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-04-25 10:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-23 10:11 [PATCH] hw/intc/i8259: Remove unused DEBUG_PIC define BALATON Zoltan
2025-04-23 10:24 ` Mark Cave-Ayland
2025-04-23 11:17 ` Philippe Mathieu-Daudé
2025-04-25 10:43 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).